* [ANN] unicorn 5.0.0.pre1 - incompatible changes!
@ 2015-06-15 22:56 4% Eric Wong
0 siblings, 0 replies; 4+ results
From: Eric Wong @ 2015-06-15 22:56 UTC (permalink / raw)
To: unicorn-public
This release finally drops Ruby 1.8 support and requires Ruby 1.9.3
or later. The horrible "Status:" header in our HTTP response is
finally gone, saving at least 16 precious bytes in every single HTTP
response.
Under Ruby 2.1 and later, the monotonic clock is used for timeout
handling for better accuracy.
Several experimental, unused and undocumented features are removed.
There's also tiny, minor performance and memory improvements from
dropping 1.8 compatibility, but probably nothing noticeable on a
typical real-life (bloated) app.
The biggest performance improvement we made was to our website by
switching to olddoc. Depending on connection speed, latency, and
renderer performance, it typically loads two to four times faster.
Finally, for the billionth time: unicorn must never be exposed
to slow clients, as it will never ever use new-fangled things
like non-blocking socket I/O, threads, epoll or kqueue. unicorn
must be used with a fully-buffering reverse proxy such as nginx
for slow clients.
I'll tag 5.0.0 final in a week or so if all goes well
= gem install --pre unicorn
= git clone git://bogomips.org/unicorn.git
= http://unicorn.bogomips.org/
* ISSUES: update with mailing list subscription
* GIT-VERSION-GEN: start 5.0.0 development
* http: remove xftrust options
* FAQ: add entry for Rails autoflush_log
* dev: remove isolate dependency
* unicorn.gemspec: depend on test-unit 3.0
* http_response: remove Status: header
* remove RubyForge and Freecode references
* remove mongrel.rubyforge.org references
* http: remove the keepalive requests limit
* http: reduce parser from 72 to 56 bytes on 64-bit
* examples: add run_once to before_fork hook example
* worker: remove old tmp accessor
* http_server: save 450+ bytes of memory on x86-64
* t/t0002-parser-error.sh: relax test for rack 1.6.0
* remove SSL support
* tmpio: drop the "size" method
* switch docs + website to olddoc
* README: clarify/reduce references to unicorn_rails
* gemspec: fixup olddoc migration
* use the monotonic clock under Ruby 2.1+
* http: -Wshorten-64-to-32 warnings on clang
* remove old inetd+git examples and exec_cgi
* http: standalone require + reduction in binary size
* GNUmakefile: fix clean gem build + reduce build cruft
* socket_helper: reduce constant lookups and caching
* remove 1.8, <= 1.9.1 fallback for missing IO#autoclose=
* favor IO#close_on_exec= over fcntl in 1.9+
* use require_relative to reduce syscalls at startup
* doc: update support status for Ruby versions
* fix uninstalled testing and reduce require paths
* test_socket_helper: do not depend on SO_REUSEPORT
* favor "a.b(&:c)" form over "a.b { |x| x.c }"
* ISSUES: add section for bugs in other projects
* http_server: favor ivars over constants
* explain 11 byte magic number for self-pipe
* const: drop constants used by Rainbows!
* reduce and localize constant string use
* Links: mark Rainbows! as historical, reference yahns
* save about 200 bytes of memory on x86-64
* http: remove deprecated reset method
* http: remove experimental dechunk! method
* socket_helper: update comments
* doc: document UNICORN_FD in manpage
* doc: document Etc.nprocessors for worker_processes
* favor more string literals for cold call sites
* tee_input: support for Rack::TempfileReaper middleware
* support TempfileReaper in deployment and development envs
* favor kgio_wait_readable for single FD over select
* Merge tag 'v4.9.0'
* http_request: support rack.hijack by default
* avoid extra allocation for hijack proc creation
* FAQ: add note about ECONNRESET errors from bodies
* process SIGWINCH unless stdin is a TTY
* ISSUES: discourage HTML mail strongly, welcome nyms
* http: use rb_hash_clear in Ruby 2.0+
* http_response: avoid special-casing for Rack < 1.5
* www: install NEWS.atom.xml properly
* http_server: remove a few more accessors and constants
* http_response: simplify regular expression
* move the socket into Rack env for hijacking
* http: move response_start_sent into the C ext
* FAQ: reorder bit on Rack 1.1.x and Rails 2.3.x
* ensure body is closed during hijack
--
EW
^ permalink raw reply [relevance 4%]
* [PATCH] http_response: avoid special-casing for Rack < 1.5
2015-05-16 21:30 7% ` [PATCH 1/2] http_request: support rack.hijack by default Eric Wong
@ 2015-05-19 20:01 4% ` Eric Wong
0 siblings, 0 replies; 4+ results
From: Eric Wong @ 2015-05-19 20:01 UTC (permalink / raw)
To: unicorn-public
Rack 1.4 and earlier will soon die out, so avoid having extra,
overengineered code and method dispatch to silently drop support
for mis-hijacking with old Rack versions.
This will cause improperly hijacked responses in all versions of
Rack to fail, but allows properly hijacked responses to work
regardless of Rack version.
Followup-to: commit fdf09e562733f9509d275cb13c1c1a04e579a68a
("http_request: support rack.hijack by default")
---
lib/unicorn/http_response.rb | 16 +++-------------
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/lib/unicorn/http_response.rb b/lib/unicorn/http_response.rb
index cc027c5..c9c2de8 100644
--- a/lib/unicorn/http_response.rb
+++ b/lib/unicorn/http_response.rb
@@ -36,9 +36,9 @@ def http_response_write(socket, status, headers, body,
when %r{\A(?:Date\z|Connection\z)}i
next
when "rack.hijack"
- # this was an illegal key in Rack < 1.5, so it should be
- # OK to silently discard it for those older versions
- hijack = hijack_prepare(value)
+ # This should only be hit under Rack >= 1.5, as this was an illegal
+ # key in Rack < 1.5
+ hijack = value
else
if value =~ /\n/
# avoiding blank, key-only cookies with /\n+/
@@ -60,14 +60,4 @@ def http_response_write(socket, status, headers, body,
ensure
body.respond_to?(:close) and body.close
end
-
- # Rack 1.5.0 (protocol version 1.2) adds response hijacking support
- if ((Rack::VERSION[0] << 8) | Rack::VERSION[1]) >= 0x0102
- def hijack_prepare(value)
- value
- end
- else
- def hijack_prepare(_)
- end
- end
end
--
EW
^ permalink raw reply related [relevance 4%]
* [PATCH 1/2] http_request: support rack.hijack by default
2015-05-16 21:30 6% [PATCH 0/2] no avoiding rack.hijack anymore Eric Wong
@ 2015-05-16 21:30 7% ` Eric Wong
2015-05-19 20:01 4% ` [PATCH] http_response: avoid special-casing for Rack < 1.5 Eric Wong
0 siblings, 1 reply; 4+ results
From: Eric Wong @ 2015-05-16 21:30 UTC (permalink / raw)
To: unicorn-public; +Cc: e
Rack 1.4 and earlier will soon die out, so avoid having extra code
The only minor overhead is assigning two hash slots and
the extra hash checks when running ancient versions of Rack,
so it is unlikely anybody cares about that overhead with Rack 1.5
and later.
---
lib/unicorn/http_request.rb | 32 +++++++++-----------------------
1 file changed, 9 insertions(+), 23 deletions(-)
diff --git a/lib/unicorn/http_request.rb b/lib/unicorn/http_request.rb
index 9888430..b32003e 100644
--- a/lib/unicorn/http_request.rb
+++ b/lib/unicorn/http_request.rb
@@ -13,13 +13,16 @@ class Unicorn::HttpParser
"rack.multiprocess" => true,
"rack.multithread" => false,
"rack.run_once" => false,
- "rack.version" => [1, 1],
+ "rack.version" => [1, 2],
+ "rack.hijack?" => true,
"SCRIPT_NAME" => "",
# this is not in the Rack spec, but some apps may rely on it
"SERVER_SOFTWARE" => "Unicorn #{Unicorn::Const::UNICORN_VERSION}"
}
+ RACK_HIJACK = "rack.hijack".freeze
+ RACK_HIJACK_IO = "rack.hijack_io".freeze
NULL_IO = StringIO.new("")
attr_accessor :response_start_sent
@@ -98,28 +101,11 @@ class Unicorn::HttpParser
e.merge!(DEFAULTS)
end
- # Rack 1.5.0 (protocol version 1.2) adds hijack request support
- if ((Rack::VERSION[0] << 8) | Rack::VERSION[1]) >= 0x0102
- DEFAULTS["rack.hijack?"] = true
- DEFAULTS["rack.version"] = [1, 2]
-
- RACK_HIJACK = "rack.hijack".freeze
- RACK_HIJACK_IO = "rack.hijack_io".freeze
-
- def hijacked?
- env.include?(RACK_HIJACK_IO)
- end
-
- def hijack_setup(e, socket)
- e[RACK_HIJACK] = proc { e[RACK_HIJACK_IO] = socket }
- end
- else
- # old Rack, do nothing.
- def hijack_setup(e, _)
- end
+ def hijacked?
+ env.include?(RACK_HIJACK_IO)
+ end
- def hijacked?
- false
- end
+ def hijack_setup(e, socket)
+ e[RACK_HIJACK] = proc { e[RACK_HIJACK_IO] = socket }
end
end
--
EW
^ permalink raw reply related [relevance 7%]
* [PATCH 0/2] no avoiding rack.hijack anymore
@ 2015-05-16 21:30 6% Eric Wong
2015-05-16 21:30 7% ` [PATCH 1/2] http_request: support rack.hijack by default Eric Wong
0 siblings, 1 reply; 4+ results
From: Eric Wong @ 2015-05-16 21:30 UTC (permalink / raw)
To: unicorn-public; +Cc: e
I'm not sure if it makes sense to use rack.hijack with a prefork server
like unicorn which only works behind nginx, but maybe somebody does...
Eric Wong (2):
http_request: support rack.hijack by default
avoid extra allocation for hijack proc creation
lib/unicorn/http_request.rb | 40 ++++++++++++++++------------------------
1 file changed, 16 insertions(+), 24 deletions(-)
^ permalink raw reply [relevance 6%]
Results 1-4 of 4 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2015-05-16 21:30 6% [PATCH 0/2] no avoiding rack.hijack anymore Eric Wong
2015-05-16 21:30 7% ` [PATCH 1/2] http_request: support rack.hijack by default Eric Wong
2015-05-19 20:01 4% ` [PATCH] http_response: avoid special-casing for Rack < 1.5 Eric Wong
2015-06-15 22:56 4% [ANN] unicorn 5.0.0.pre1 - incompatible changes! Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).