* unicorn prerelease 0.990.0.5.gbfb1
@ 2010-06-08 22:36 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2010-06-08 22:36 UTC (permalink / raw)
To: unicorn list
Hi all,
I decided to try out the prerelease feature of Rubygems
for the first time, it seems to work...
So yes, "gem install --pre unicorn" if you're using Rails 3
(and probably like to type 'rm config.ru' :>)
Same list of changes since v0.990.0:
Eric Wong (4):
t0300: Rails 3 test actually uses unicorn_rails
tests: libify common rails3 setup code
unicorn_rails: fix requires for Ruby 1.9.2
tests: add Rails 3 test for the missing config.ru case
Hongli Lai (Phusion) (1):
Fix unicorn_rails compatibility with the latest Rails 3 code
--
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply [relevance 7%]
* Re: unicorn_rails cleanup (possible fix for Rails3) pushed
@ 2010-06-08 20:55 7% ` Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2010-06-08 20:55 UTC (permalink / raw)
To: unicorn list; +Cc: Hongli Lai
Hongli Lai <hongli@phusion.nl> wrote:
> On Tue, Jun 8, 2010 at 9:20 PM, Eric Wong <normalperson@yhbt.net> wrote:
> > Thanks Hongli, so this only affects people who remove the
> > config.ru that Rails 3 creates for them? Yikes...
>
> No. The problem even occurs if you already have config.ru. But the
> thing is, Rails 3 has deprecated ActionController::Dispatcher a few
> weeks ago and replaced it with a stub. Rails::Rack::Static changed its
> interface and must be constructed differently. The only way to obtain
> a valid Rack endpoint for the app seems to be parsing
> config/application.rb
Actually, I made "unicorn_rails" completely bypass the "rails_builder"
method if there's a config.ru, so it should never hit the
ActionController::Dispatcher stuff.
> > Let me know if the edited patch below looks alright to you.
>
> Yes it looks fine. A bit overcomplicated regexp compared to using
> 'strip' but whatever works. :)
I just kept the regexp as-is, works for me.
I just managed to push this to git://git.bogomips.org/unicorn.git before
my Internet connection died on me earlier today. I've beefed up the
tests a bit but will probably do more later.
Eric Wong (4):
t0300: Rails 3 test actually uses unicorn_rails
tests: libify common rails3 setup code
unicorn_rails: fix requires for Ruby 1.9.2
tests: add Rails 3 test for the missing config.ru case
Hongli Lai (Phusion) (1):
Fix unicorn_rails compatibility with the latest Rails 3 code
Thanks again!
--
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2010-06-08 12:24 unicorn_rails cleanup (possible fix for Rails3) pushed Hongli Lai
2010-06-08 19:20 ` Eric Wong
2010-06-08 19:25 ` Hongli Lai
2010-06-08 20:55 7% ` Eric Wong
2010-06-08 22:36 7% unicorn prerelease 0.990.0.5.gbfb1 Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).