unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download mbox.gz: |
* [PATCH 1/2] test_server: test_early_hints: fix test reliability
  2020-07-23  4:17  6% [PATCH 0/2] some minor early_hints fixes Eric Wong
@ 2020-07-23  4:17  7% ` Eric Wong
  0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2020-07-23  4:17 UTC (permalink / raw)
  To: unicorn-public; +Cc: Jean Boussier

IO#sysread may only capture the 103 response and return before
the server can send the 200.  Since we don't support persistent
connections, we can just use IO#read to rely on the server
giving us an EOF after the 200 is sent.

Cc: Jean Boussier <jean.boussier@gmail.com>
---
 test/unit/test_server.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit/test_server.rb b/test/unit/test_server.rb
index d706243..384fa6b 100644
--- a/test/unit/test_server.rb
+++ b/test/unit/test_server.rb
@@ -106,7 +106,7 @@ def test_early_hints
     sock = TCPSocket.new('127.0.0.1', @port)
     sock.syswrite("GET / HTTP/1.0\r\n\r\n")
 
-    responses = sock.sysread(4096)
+    responses = sock.read(4096)
     assert_match %r{\AHTTP/1.[01] 103\b}, responses
     assert_match %r{^Link: </style\.css>}, responses
     assert_match %r{^Link: </script\.js>}, responses

^ permalink raw reply	[relevance 7%]

* [PATCH 0/2] some minor early_hints fixes
@ 2020-07-23  4:17  6% Eric Wong
  2020-07-23  4:17  7% ` [PATCH 1/2] test_server: test_early_hints: fix test reliability Eric Wong
  0 siblings, 1 reply; 2+ results
From: Eric Wong @ 2020-07-23  4:17 UTC (permalink / raw)
  To: unicorn-public; +Cc: Jean Boussier

Just some minor things:

I noticed the new test failed occasionally, and made a trivial
fix for it.  In case people use SIGHUP, I've also made it reset
back to the default value (just like every other config
variable).

Eric Wong (2):
  test_server: test_early_hints: fix test reliability
  configurator: SIGHUP resets early_hints if unset

 lib/unicorn/configurator.rb | 1 +
 test/unit/test_server.rb    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

^ permalink raw reply	[relevance 6%]

Results 1-2 of 2 | reverse | sort options + mbox downloads above
-- links below jump to the message on this page --
2020-07-23  4:17  6% [PATCH 0/2] some minor early_hints fixes Eric Wong
2020-07-23  4:17  7% ` [PATCH 1/2] test_server: test_early_hints: fix test reliability Eric Wong

Code repositories for project(s) associated with this inbox:

	../unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).