* [ANN] unicorn 4.7.0 - minor updates, license tweak
@ 2013-11-04 7:57 5% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2013-11-04 7:57 UTC (permalink / raw)
To: mongrel-unicorn
* git://bogomips.org/unicorn.git
* http://unicorn.bogomips.org/NEWS.atom.xml
Changes:
* support SO_REUSEPORT on new listeners (:reuseport)
This allows users to start an independent instance of unicorn on
a the same port as a running unicorn (as long as both instances
use :reuseport).
ref: https://lwn.net/Articles/542629/
* unicorn is now GPLv2-or-later and Ruby 1.8-licensed
(instead of GPLv2-only, GPLv3-only, and Ruby 1.8-licensed)
This changes nothing at the moment. Once the FSF publishes the next
version of the GPL, users may choose the newer GPL version without the
unicorn BDFL approving it. Two years ago when I got permission to add
GPLv3 to the license options, I also got permission from all past
contributors to approve future versions of the GPL. So now I'm
approving all future versions of the GPL for use with unicorn.
Reasoning below:
In case the GPLv4 arrives and I am not alive to approve/review it,
the lesser of evils is have give blanket approval of all future GPL
versions (as published by the FSF). The worse evil is to be stuck
with a license which cannot guarantee the Free-ness of this project
in the future.
This unfortunately means the FSF can theoretically come out with
license terms I do not agree with, but the GPLv2 and GPLv3 will
always be an option to all users.
Note: we currently prefer GPLv3
Two improvements thanks to Ernest W. Durbin III:
* USR2 redirects fixed for Ruby 1.8.6 (broken since 4.1.0)
* unicorn(1) and unicorn_rails(1) enforces valid integer for -p/--port
A few more odd, minor tweaks and fixes:
* attempt to rename PID file when possible (on USR2)
* workaround reopen atomicity issues for stdio vs non-stdio
* improve handling of client-triggerable socket errors
--
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply [relevance 5%]
* [RFC] workaround reopen atomicity issues for stdio vs non-stdio
@ 2013-10-20 4:44 7% Eric Wong
0 siblings, 0 replies; 2+ results
From: Eric Wong @ 2013-10-20 4:44 UTC (permalink / raw)
To: mongrel-unicorn; +Cc: rainbows-talk
In multithreaded apps, we must use dup2/dup3 with a temporary
descriptor to reopen log files atomically. This is the only way
to protect all concurrent userspace access to a file when reopening.
ref: http://bugs.ruby-lang.org/issues/9036
ref: yahns commit bcb10abe53cfb1d6a8ef7daef59eb10ced397c8a
---
Review of this patch is greatly appreciated. This doesn't affect most
unicorn users unless they spawn threads themselves and write to log
files in their app. This does affect Rainbows! users who configure
Rainbows! to use threads, though.
Also, I guess I should announce yahns on these lists for those not on
ruby-talk: http://yahns.yhbt.net/README
git clone git://yhbt.net/yahns - not for production, yet, but soon
I can write HTTP servers all day long, really, I just can't stand
web browsers :P
lib/unicorn/util.rb | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/lib/unicorn/util.rb b/lib/unicorn/util.rb
index f84241c..94c4e37 100644
--- a/lib/unicorn/util.rb
+++ b/lib/unicorn/util.rb
@@ -39,7 +39,7 @@ module Unicorn::Util
to_reopen.each do |fp|
orig_st = begin
fp.stat
- rescue IOError, Errno::EBADF
+ rescue IOError, Errno::EBADF # race
next
end
@@ -50,8 +50,28 @@ module Unicorn::Util
end
begin
- File.open(fp.path, 'a') { |tmpfp| fp.reopen(tmpfp) }
+ # stdin, stdout, stderr are special. The following dance should
+ # guarantee there is no window where `fp' is unwritable in MRI
+ # (or any correct Ruby implementation).
+ #
+ # Fwiw, GVL has zero bearing here. This is tricky because of
+ # the unavoidable existence of stdio FILE * pointers for
+ # std{in,out,err} in all programs which may use the standard C library
+ if fp.fileno <= 2
+ # We do not want to hit fclose(3)->dup(2) window for std{in,out,err}
+ # MRI will use freopen(3) here internally on std{in,out,err}
+ fp.reopen(fp.path, "a")
+ else
+ # We should not need this workaround, Ruby can be fixed:
+ # http://bugs.ruby-lang.org/issues/9036
+ # MRI will not call call fclose(3) or freopen(3) here
+ # since there's no associated std{in,out,err} FILE * pointer
+ # This should atomically use dup3(2) (or dup2(2)) syscall
+ File.open(fp.path, "a") { |tmpfp| fp.reopen(tmpfp) }
+ end
+
fp.sync = true
+ fp.flush # IO#sync=true may not implicitly flush
new_st = fp.stat
# this should only happen in the master:
--
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply related [relevance 7%]
Results 1-2 of 2 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2013-10-20 4:44 7% [RFC] workaround reopen atomicity issues for stdio vs non-stdio Eric Wong
2013-11-04 7:57 5% [ANN] unicorn 4.7.0 - minor updates, license tweak Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).