unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Jean Boussier <jean.boussier@gmail.com>
To: unicorn-public@yhbt.net
Subject: [PATCH] Make the gem usable as a git gem
Date: Fri, 8 Jul 2022 09:46:51 +0200	[thread overview]
Message-ID: <A035FC5A-9859-48E0-9BC0-809BAE645B9A@gmail.com> (raw)

Ok, so I’m sorry, but I’ve now tried for hours and
I can’t for the life of me figure out how to send a patch
cleanly with the tools I have available.

So you can download the patch here:
https://github.com/byroot/unicorn/commit/e7f49852875de54cce974c7cbdd5540ddc5e4eeb.patch

—— 

Bundler allow to install arbitrary revision
of a gem via its git repository, e.g.

```ruby
gem "unicorn", git: "https://yhbt.net/unicorn.git"
```

But this currently doesn't work with unicorn because
some files are not committed, and they are only generated
by the makefile.

This change would make it much easier to test
unreleased versions.

NB: I didn't commit ext/unicorn_http/unicorn_http.c
because I think you might as well generate it and commit
it yourself so that you don't have to review it.
---
 .gitignore             | 2 --
 lib/unicorn/version.rb | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)
 create mode 100644 lib/unicorn/version.rb

diff --git a/.gitignore b/.gitignore
index ad92808..9aa3cad 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,7 +11,6 @@
 /test/rbx-*
 /test/ruby-*
 ext/unicorn_http/Makefile
-ext/unicorn_http/unicorn_http.c
 log/
 pkg/
 /vendor
@@ -21,5 +20,4 @@ pkg/
 /man
 /tmp
 /LATEST
-/lib/unicorn/version.rb
 /*_1
diff --git a/lib/unicorn/version.rb b/lib/unicorn/version.rb
new file mode 100644
index 0000000..f456bdd
--- /dev/null
+++ b/lib/unicorn/version.rb
@@ -0,0 +1 @@
+Unicorn::Const::UNICORN_VERSION = '6.1.0.dirty'
-- 
2.11.0


             reply	other threads:[~2022-07-08  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-08  7:46 Jean Boussier [this message]
2022-07-08 12:12 ` [PATCH] Make the gem usable as a git gem Eric Wong
2022-07-08 12:44   ` Jean Boussier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A035FC5A-9859-48E0-9BC0-809BAE645B9A@gmail.com \
    --to=jean.boussier@gmail.com \
    --cc=unicorn-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).