From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4C3C71F66F for ; Thu, 3 Sep 2020 08:29:06 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id b79so1961260wmb.4 for ; Thu, 03 Sep 2020 01:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iuB9ZyRZNDVQcvi96hMJM5obcU/UPY0DhMXOxi0kvVM=; b=c4D1A8lq8DFbEuRCzeG2uikK3g3vvRxn7vlihUWdws0H5JxxFnpgWdP7J6dOP5Ao+r LPFQ/Yfb7rewWNTc7ZkEdu8m2B7ZnSmq1biWVg8iBE803jMIIZsQN8B762hiLNROGceb Y5/AqFooSP1B1JEhs6gqNr4+FAM+jaP2twpIc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iuB9ZyRZNDVQcvi96hMJM5obcU/UPY0DhMXOxi0kvVM=; b=dge6ueTIhqyKiRhxN8zODzNB4BYCMAcBZM7tp9di2Ap110MGDiT+rSE3INW19b+f51 +RtxH4mAidkq6ZwSsXxbt6iC/NCuWpRB0eIH2OmsDvgrdkW/+VKWXDRQskBuZrQ/0iUH b3aMsIxNNye841U1iBE+bnZLbJ5lw4ZdTm1k/8+rDXfW4234KYwUJaw2W0th8ivdeV8R OtVHrvrXHmnm5jIFvXWaacqB01OGIaRzRJSZQJBIxyGRXflOIvABCKJ9cvru3mzPpMHw lo9oGTajgbtn6YDtENrYT+dHvmZnuAOCSqWXMMxAF9jqT9S2TF2cXis9PPNkZv+vmc7E 4vDg== X-Gm-Message-State: AOAM533TPMnCujO5ItTvK6Di7nmiCJureXt9xNc+swxXwIy5qSIkwn7G QWK18kj1FDnYHv5I80SpPekiYzu73gQr5g== X-Google-Smtp-Source: ABdhPJxWSmHMAE6crXyViMRErGXJdFL2rOgDcxqdV5CajDSVcSNU9qs7eaTdqVDeeV0rqXd8BrWnHw== X-Received: by 2002:a1c:f311:: with SMTP id q17mr1304813wmq.92.1599121742799; Thu, 03 Sep 2020 01:29:02 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id i6sm2098373wra.1.2020.09.03.01.29.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Sep 2020 01:29:02 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <20200903082513.GA21482@dcvr> Date: Thu, 3 Sep 2020 10:29:01 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: 7bit Message-Id: References: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> <20200901144829.GA8068@dcvr> <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: >> That could work yes. Something akin to: >> "This ruby version wasn't tested, blah blah". > > OK, can you send a patch for that? I will once I have something working on 3.0. >> I'm trying to figure out why the symbol isn't exported, >> I might come back with another patch. But just in case >> you might have an idea what's going on. > > I haven't built+tested ruby.git in ages (my computers are too slow). > It could be a failure to completely clean out the old 2.8 stuff > (either in the Ruby worktree, install paths, or unicorn worktree). I don't think so, I'm building from a fresh docker image + fresh unicorn clone. I also tested other similar gems (e.g. puma) and they export the functions just fine. I have to admit that I don't understand enough about the build process to figure out what's going on, so I'm not very confident I'll find a fix.