unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Blake Williams <blake@blakewilliams.me>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Add rack.after_reply functionality
Date: Wed, 9 Dec 2020 18:44:48 -0500	[thread overview]
Message-ID: <B43CFE10-61C3-4A7A-A57E-410D671C31DC@blakewilliams.me> (raw)
In-Reply-To: <20201209221839.GA15862@dcvr>


> Thanks, pushed to https://yhbt.net/unicorn.git as
> commit 673c15e3f020bccc0336838617875b26c9a45f4e
> with Puma noted (see below) and extra `env' check added.
> 
> Anything else?  Will wait a few days/week for others to chime in
> and probably cut 5.8 in a week or so.

Thanks, that should be everything on my end. Looking forward to the
release.

> Btw, a sidenote about some strangeness in your mail replies:
> 
>  I'm not sure why, but your "Reply-To" header is set to the
>  unbracketed Message-ID ("20201209094344.GA25593@dcvr") of the
>  message, which makes no sense...
> 
>  I wonder if you or your mail client is confusing "Reply-To:"
>  with the "In-Reply-To:" header.  They're completely different:
>  "Reply-To:" should be an email address you control (not a
>  Message-ID) if it differs from what's in the "From:" header.
> 
>  In any case, your mail client already sets the "References:"
>  header correctly (probably w/o any interaction on your part),
>  and the "In-Reply-To:" header is not necessary (and it needs
>  angle brackets, anyways, since comments are allowed).
> 
>  cf. https://www.jwz.org/doc/threading.html

Strange, thanks for the heads up. I’ve updated the settings, so
hopefully that issue is resolved.

      reply	other threads:[~2020-12-09 23:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 21:47 [PATCH] Add rack.after_reply functionality Blake Williams
2020-12-08 22:46 ` Eric Wong
2020-12-08 23:48   ` Blake Williams
2020-12-09  9:43     ` Eric Wong
2020-12-09 14:58       ` Blake Williams
2020-12-09 22:18         ` Eric Wong
2020-12-09 23:44           ` Blake Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B43CFE10-61C3-4A7A-A57E-410D671C31DC@blakewilliams.me \
    --to=blake@blakewilliams.me \
    --cc=e@80x24.org \
    --cc=unicorn-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).