From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@yhbt.net>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Add early hints support
Date: Thu, 16 Jul 2020 14:24:15 +0200 [thread overview]
Message-ID: <C0BBAE49-63DA-4629-996B-29B3EB21B90E@shopify.com> (raw)
In-Reply-To: <20200716121643.GA26942@dcvr>
> Alright, numbers would've been helpful but I'll take your word
> for it.
My bad, I didn't get the hint:
```
require 'benchmark/ips'
class Foo
attr_accessor :foo
def initialize
@foo = 1
end
def missing_ivar
@bar
end
def ivar
@foo
end
def accessor
foo
end
end
foo = Foo.new
Benchmark.ips do |x|
x.report('ivar') { foo.ivar }
x.report('attr') { foo.accessor }
x.report('ivar:missing') { foo.missing_ivar }
x.compare!
end
```
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
Warming up --------------------------------------
ivar 2.105M i/100ms
attr 1.824M i/100ms
ivar:missing 1.795M i/100ms
Calculating -------------------------------------
ivar 20.935M (± 1.5%) i/s - 105.248M in 5.028625s
attr 18.622M (± 0.8%) i/s - 94.845M in 5.093471s
ivar:missing 18.408M (± 1.1%) i/s - 93.357M in 5.072160s
Comparison:
ivar: 20934740.7 i/s
attr: 18622122.9 i/s - 1.12x (± 0.00) slower
ivar:missing: 18408273.1 i/s - 1.14x (± 0.00) slower
So yeah, the difference between raw @ivar and an attr_reader is barely noticeable, and both are very fast.
next prev parent reply other threads:[~2020-07-16 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 10:05 [PATCH] Add early hints support Jean Boussier
2020-07-16 10:50 ` Eric Wong
2020-07-16 11:41 ` Jean Boussier
2020-07-16 12:16 ` Eric Wong
2020-07-16 12:24 ` Jean Boussier [this message]
2020-07-17 1:19 ` Eric Wong
2020-07-20 9:18 ` Jean Boussier
2020-07-20 10:09 ` Eric Wong
2020-07-20 10:27 ` Jean Boussier
2020-07-20 10:55 ` Eric Wong
2020-07-20 11:53 ` Jean Boussier
2020-07-20 20:27 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C0BBAE49-63DA-4629-996B-29B3EB21B90E@shopify.com \
--to=jean.boussier@shopify.com \
--cc=e@yhbt.net \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).