From: Sam Saffron <sam.saffron@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+
Date: Wed, 2 Apr 2014 21:05:00 +1100 [thread overview]
Message-ID: <CAAtdryPOz5vn1xSmE8n+ePnwXnOMUNDFxQCnQe+STjJTXKJNew@mail.gmail.com> (raw)
In-Reply-To: <20140402095555.GA1493@dcvr.yhbt.net>
Looks perfect to me. Thanks heaps
On Wed, Apr 2, 2014 at 8:55 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Sam Saffron <sam.saffron@gmail.com> wrote:
>> Perhaps link to
>> https://github.com/discourse/discourse/blob/master/lib/middleware/unicorn_oobgc.rb
>> for a 2.0 compatible solution (for people not on 2.1 yet)
>
> OK. I prefer to link to the repo homepage/root to give the top-level
> project more visibility and also avoid long URLs.
>
> How about this?
>
> --- a/lib/unicorn/oob_gc.rb
> +++ b/lib/unicorn/oob_gc.rb
> @@ -4,6 +4,10 @@
> # It is built on new APIs in Ruby 2.1, so it is more intelligent than
> # this historical implementation.
> #
> +# Users on Ruby 2.0 (not 2.1+) may also want to check out
> +# lib/middleware/unicorn_oobgc.rb from the Discourse project
> +# (https://github.com/discourse/discourse)
> +#
> # The following information is only for historical versions of Ruby.
> #
> # Runs GC after requests, after closing the client socket and
> _______________________________________________
> Unicorn mailing list - mongrel-unicorn@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-unicorn
> Do not quote signatures (like this one) or top post when replying
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2014-04-02 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 1:35 [RFC] oobgc: link to Aman's gctools for Ruby 2.1+ Eric Wong
2014-03-29 21:50 ` Aman Gupta
2014-04-02 4:55 ` Sam Saffron
2014-04-02 9:55 ` Eric Wong
2014-04-02 10:05 ` Sam Saffron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAtdryPOz5vn1xSmE8n+ePnwXnOMUNDFxQCnQe+STjJTXKJNew@mail.gmail.com \
--to=sam.saffron@gmail.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).