From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: * X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=1.3 required=5.0 tests=AWL,FREEMAIL_FROM,RDNS_NONE, T_DKIM_INVALID shortcircuit=no autolearn=no version=3.3.2 X-Original-To: archivist@yhbt.net Delivered-To: archivist@dcvr.yhbt.net Received: from rubyforge.org (unknown [50.56.192.79]) by dcvr.yhbt.net (Postfix) with ESMTP id B9CA720D1F for ; Wed, 2 Apr 2014 10:13:01 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 876842E21B; Wed, 2 Apr 2014 10:12:59 +0000 (UTC) X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Received: from mail-qa0-f52.google.com (mail-qa0-f52.google.com [209.85.216.52]) by rubyforge.org (Postfix) with ESMTP id 662CC2E21B for ; Wed, 2 Apr 2014 10:12:52 +0000 (UTC) Received: by mail-qa0-f52.google.com with SMTP id m5so10749072qaj.39 for ; Wed, 02 Apr 2014 03:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=639UWCMN8JKGvJzk3mYU08xhQl+UKIKqlJCwMOwDUYU=; b=JjoOklBxBkSd/OIj950fRbHYiQR41ccaekSpAAF5mCm+BJTTnYufI6cGLgkv6YFvMm /Ta2Us6UnqujpHiqHq9xk5+KCr58OrBwZzhOArtRzsb+jirXVQJGseNm/4xx4+wHTlqy gquMDx9ULt4sXORSFtaVy+64Ja7rC3SA7NPCeLzfF+H+/E96kme4xze49DHBUNT/R+Gs UZ0iWwPeaVnmU9AGltk5py4YC1kihhtPkGuiYUT0+h2r1t+xZusz/rpttZFzth1U5H/l YyTLTwGWdbGg4iC59XTFzP5i3/3qv/ZKtAV+9tjMenmkherlECN759QoHLh3BxjdYby2 5TYA== MIME-Version: 1.0 X-Received: by 10.224.87.132 with SMTP id w4mr250907qal.89.1396433100334; Wed, 02 Apr 2014 03:05:00 -0700 (PDT) Received: by 10.229.28.138 with HTTP; Wed, 2 Apr 2014 03:05:00 -0700 (PDT) In-Reply-To: <20140402095555.GA1493@dcvr.yhbt.net> References: <20140329013534.GA10450@dcvr.yhbt.net> <20140402095555.GA1493@dcvr.yhbt.net> Date: Wed, 2 Apr 2014 21:05:00 +1100 Message-ID: Subject: Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+ From: Sam Saffron To: unicorn list X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org Looks perfect to me. Thanks heaps On Wed, Apr 2, 2014 at 8:55 PM, Eric Wong wrote: > Sam Saffron wrote: >> Perhaps link to >> https://github.com/discourse/discourse/blob/master/lib/middleware/unicorn_oobgc.rb >> for a 2.0 compatible solution (for people not on 2.1 yet) > > OK. I prefer to link to the repo homepage/root to give the top-level > project more visibility and also avoid long URLs. > > How about this? > > --- a/lib/unicorn/oob_gc.rb > +++ b/lib/unicorn/oob_gc.rb > @@ -4,6 +4,10 @@ > # It is built on new APIs in Ruby 2.1, so it is more intelligent than > # this historical implementation. > # > +# Users on Ruby 2.0 (not 2.1+) may also want to check out > +# lib/middleware/unicorn_oobgc.rb from the Discourse project > +# (https://github.com/discourse/discourse) > +# > # The following information is only for historical versions of Ruby. > # > # Runs GC after requests, after closing the client socket and > _______________________________________________ > Unicorn mailing list - mongrel-unicorn@rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-unicorn > Do not quote signatures (like this one) or top post when replying _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying