From: Adam Duke <adamduke@twitter.com>
To: unicorn-public@bogomips.org
Subject: [PATCH] limit rack version for ruby compatibility
Date: Fri, 8 Jan 2016 13:34:57 -0500 [thread overview]
Message-ID: <CACj6Wog0=R6Wsh1U5SFE6r1BdWBr4Loe+GM6UKdObSALwAj9JQ@mail.gmail.com> (raw)
From 6f1cb0ae4b63bd1906fd83d154dae1d1f2b35407 Mon Sep 17 00:00:00 2001
From: Adam Duke <adam.v.duke@gmail.com>
Date: Fri, 8 Jan 2016 13:06:31 -0500
Subject: [PATCH] limit rack version for ruby compatibility
rack introduced a dependency on ruby 2.2.2 or greater in
https://github.com/rack/rack/commit/771d94e5dbe53058160a1f8a4cc56384c1d2a048
In order to maintain support for ruby versions less than 2.2.2, limit
the rack dependency to supported versions for the current ruby.
---
unicorn.gemspec | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/unicorn.gemspec b/unicorn.gemspec
index 1099361..ce7080a 100644
--- a/unicorn.gemspec
+++ b/unicorn.gemspec
@@ -35,7 +35,11 @@
# up/downgrade to any other version, the Rack dependency may be
# commented out. Nevertheless, upgrading to Rails 2.3.4 or later is
# *strongly* recommended for security reasons.
- s.add_dependency(%q<rack>)
+ if RUBY_VERSION < '2.2.2'
+ s.add_dependency(%q<rack>, '~> 1.6.4')
+ else
+ s.add_dependency(%q<rack>)
+ end
s.add_dependency(%q<kgio>, '~> 2.6')
s.add_dependency(%q<raindrops>, '~> 0.7')
--
2.6.4
next reply other threads:[~2016-01-08 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 18:34 Adam Duke [this message]
2016-01-08 19:18 ` [PATCH] limit rack version for ruby compatibility Eric Wong
2016-01-08 21:50 ` Aaron Patterson
2016-01-08 21:56 ` Aaron Patterson
2016-01-08 22:13 ` Adam Duke
2016-01-08 22:17 ` Aaron Patterson
2016-01-08 22:37 ` Eric Wong
2016-01-08 23:19 ` Aaron Patterson
2016-01-21 17:12 ` Adam Duke
2016-01-21 20:12 ` Eric Wong
2016-01-21 22:09 ` Aaron Patterson
2016-01-27 0:47 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACj6Wog0=R6Wsh1U5SFE6r1BdWBr4Loe+GM6UKdObSALwAj9JQ@mail.gmail.com' \
--to=adamduke@twitter.com \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).