unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Carl Brasic <cbrasic@gmail.com>
Cc: unicorn-public <unicorn-public@bogomips.org>
Subject: Re: Log URL with murder_lazy_workers
Date: Mon, 15 Jan 2018 09:06:41 -0600	[thread overview]
Message-ID: <CAD-jRAf==xMaiMj6FXTAUGjc6H8=jNXc6mYu9iFW6gJzK9TC_w@mail.gmail.com> (raw)
In-Reply-To: <CAAtdryM9pRQwE+hkSgMckRxhCXTxKOAxn+3ejZkZwaGaNk7vWg@mail.gmail.com>

We solved this issue by writing a small rack middleware that launches a
background thread for every request that sleeps for one second short of the
unicorn timeout and then logs some info (including the URL) to a file.

The nice thing about this approach is that you have access to the main thread's
information, including env['action_controller.instance'] to get controller
params, current user information, app backtrace, etc.  That last one in
particular has been very valuable in diagnosing complex performance problems.

In very high volume applications the thread per request model might be a
bottleneck, it could be modified to a persistent buddy thread approach.

Carl

On Sun, Jan 14, 2018 at 5:27 PM, Sam Saffron <sam.saffron@gmail.com> wrote:
> I would love to start logging the actual URL that timed out when
> murder_lazy_workers does its thing.
>
> Clearly the master process has no knowledge here, but perhaps if we
> had a named pipe from each child to master we could quickly post
> current url down the pipe so we would have something to log when we
> murder a url.
>
> Clearly an opt-in thing, but would be very handy for quick diagnostics
> cause we can then avoid deeper log analysis and raise events just as
> this happens.
>

      parent reply	other threads:[~2018-01-15 15:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 23:27 Log URL with murder_lazy_workers Sam Saffron
2018-01-15  1:57 ` Eric Wong
2018-01-15  2:18   ` Sam Saffron
     [not found]     ` <CADGZSScpXo7-PvM=Ki64hhPSzWAsjyT+fWKAZ9-30U69x+54iA@mail.gmail.com>
2018-01-15  3:22       ` Sam Saffron
2018-01-15 15:06 ` Carl Brasic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD-jRAf==xMaiMj6FXTAUGjc6H8=jNXc6mYu9iFW6gJzK9TC_w@mail.gmail.com' \
    --to=cbrasic@gmail.com \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).