From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Status: No, score=0.1 required=3.0 tests=AWL,RCVD_IN_DNSWL_LOW shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: unicorn-public@bogomips.org Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 61D721FF84 for ; Tue, 13 May 2014 00:46:17 +0000 (UTC) Received: by mail-la0-f50.google.com with SMTP id b8so2493606lan.37 for ; Mon, 12 May 2014 17:46:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2WPJwRwohRBDeFoDSdlRs/5Zs/qFwrffnLGslQpSJXs=; b=VVpjQjH7ncuK1t08+U7UrteQ+t4MvG3PZwV5JCaqoPBJn9/E6YGPxHE4dGAIMc2wYi ruxYmrOXEwsWP+P6zPaAfK8s/jGI3gQf/I6Okh7v8h5uG1CcYUmUD0Y7L8QefUFu543p pnrOjslAnbMNnpJYeZ+hNpy2/IvYBwloi9B1/mSUNtYnqeaLWcWTCPl0BiruOWGs2hjK LDhrnZypxnqNlTz7Oy9lZDLBSRd0g4JYZFdixcH5+s4rGm0sYhck3DD4OatOVDFk8YO3 k8+H7OBqDVJR34gVmeMo2v2qkZBz1KSaV6qgRhNsPhEwww+Kdiy194kukm8iNL4LJ4Sp CNsA== X-Gm-Message-State: ALoCoQnKzJZqm1FQ7O3wNeIXOIeXOgVCS93PWGhObOo6JzKhBKTzGn6eeFFCVIMeziGLkAW9N9l/ MIME-Version: 1.0 X-Received: by 10.112.85.167 with SMTP id i7mr10468700lbz.32.1399941975085; Mon, 12 May 2014 17:46:15 -0700 (PDT) Received: by 10.112.44.193 with HTTP; Mon, 12 May 2014 17:46:15 -0700 (PDT) In-Reply-To: <20140426060744.GA17493@dcvr.yhbt.net> References: <1398482426-3245-1-git-send-email-ktdreyer@ktdreyer.com> <20140426060744.GA17493@dcvr.yhbt.net> Date: Mon, 12 May 2014 18:46:15 -0600 Message-ID: Subject: Re: [PATCH] tests: switch to minitest From: Ken Dreyer To: Eric Wong Cc: unicorn-public@bogomips.org, mongrel-unicorn@rubyforge.org Content-Type: text/plain; charset=UTF-8 List-Id: On Sat, Apr 26, 2014 at 12:07 AM, Eric Wong wrote: > Ken Dreyer wrote: >> Ruby 1.9+ uses Minitest as the backend for Test::Unit. As of Minitest 5, >> the shim has lost some backwards compatibility. It is time to make the >> jump to minitest. >> >> Adjust the unicorn test suite to support Minitest 5's syntax. > > Thank you very much for taking a look at this. I was going to do it > myself over the summer. > > I ran into some problems with our tests forking + minitest/autorun > causing some problems due to at_exit usage. Hi Eric, Thanks very much for looking over my patch. I've taken a look at yahns and the changes you made there, and I've also been testing Unicorn here with my patch. I'm a bit confused about your comments regarding the problems with forking and minitest/autorun, because I'm not personally seeing test failures regarding forking and my patch. I am seeing one failure with the final assert in TestSocketHelper#test_bind_listen_unix_rebind, but I don't think that's a result of this, right? Would you mind pointing me in the right direction? - Ken