From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0E6F01FAE2 for ; Tue, 27 Feb 2018 04:04:09 +0000 (UTC) Received: by mail-qt0-x231.google.com with SMTP id f4so21591475qtj.6 for ; Mon, 26 Feb 2018 20:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1jkLX/aENzd9ZxypOlicek/CgEfXOf8A+hqt7OhMm9g=; b=Z4Lip8GNPIgD5jROzRYPvQ614BEqQk2CFt0xozkd27jTr0Ay7x/CpOVZmfHJU1Ce0X /PNyuiZoQJTjWkBxNvZUia6Nu8n8r19JG1Wv9UCvnF8qQheH0Ftg7oST5+4Ps0O+XQqv jOJdbhlI5knQwlffOOS7pPsB9POjOrmgXyrdwYC1igyv35bWL8Mfa371auOd4D8Be2bh on6/X0liM3u6y4nqHMrqVCDS4Uu/fDEdQOyp15p2S55Q5fVr/XNSO1k+fCKPdLe9G4op rAirOk5ofSk7vnJCBfY2pgcNDFKE+6IrZVrOO+pibHtGoqjLY0PRVuim9zvkwvZcX5ML 5IhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1jkLX/aENzd9ZxypOlicek/CgEfXOf8A+hqt7OhMm9g=; b=Xari/RLNW384i4S+kLBtgUjOXLmOrl3w6psAIjVuFi2HNSRG8Dly2ApDdB35pbBGly qQ60I6qvADD9do8GULdUhK5TviSQ6JUxMhIKF0i7K6aJ+16+HIaP49dytaB+2ohfvAtB jK2yeATF8q+/rwR/6CmdtApa/uFIMr80taDbBgmFQeNdu3m8yAiUjw843FfFnPJ1c+xg V5zbXPOT24snXQAzxJJzXrf/qNcfO2sbVfVqGu3uNVNXXPaDzhuu9nNAj+XWXvkwZKaF kvUfL5xqUbNFqeliH9ExLeqBFtKMslo7FGkJKsQn4zUOcOXphQnTSydFqMikxwRqV3zZ w2mw== X-Gm-Message-State: APf1xPAkTHFIuDt08hd9NOLNnTPwJhoKMxDKtxGm8mBApYQk89T5VPFu aJF+KqUhupgTkL3/uKglGsVJx8ckimvV4CdlqIxuku2/ X-Google-Smtp-Source: AG47ELv57Qf+gGriOBcVZNftnI2sD5SIXXrCa4GJfR6+h1b/UkFl9FF17kxKioQWdXzbjb8DKk3iQSeQBtHgSm+vJjM= X-Received: by 10.200.14.140 with SMTP id v12mr21100653qti.289.1519704247855; Mon, 26 Feb 2018 20:04:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.156.196 with HTTP; Mon, 26 Feb 2018 20:03:47 -0800 (PST) In-Reply-To: <20180224151559.GA15504@whir> References: <20180224084823.25418-1-mtsmfm@gmail.com> <20180224151559.GA15504@whir> From: Fumiaki Matsushima Date: Tue, 27 Feb 2018 13:03:47 +0900 Message-ID: Subject: Re: [PATCH] Send SIGTERM before SIGKILL on timeout To: unicorn-public@bogomips.org Cc: Eric Wong , Fumiaki Matsushima Content-Type: text/plain; charset="UTF-8" List-Id: Thank you for your reply! > Right, it's been rejected several times before: Sorry, I missed these emails. > I don't want to encourage lazy app development or Rack apps written with only unicorn in mind That's true. I'll use rack-timeout to solve my timeout problem. Thanks. On Sun, Feb 25, 2018 at 12:15 AM, Eric Wong wrote: > Fumiaki MATSUSHIMA wrote: >> To output log / send error to error tracking service, >> we need to receive a signal other than SIGKILL first. >> --- >> Hi Unicorn team, >> >> I'm not sure this change is accetable though, >> I can find some articles and patches to prevent SIGKILL >> on timeout. > > Right, it's been rejected several times before: > > https://bogomips.org/unicorn-public/20140416084416.GA9709@dcvr.yhbt.net/t/#u > https://bogomips.org/unicorn-public/20180115015740.GA850@dcvr/t/#u > >> I think it's great if this feature is supported by unicorn itself. >> >> Could you give me your opinion? > > Again, I don't want to encourage lazy app development or Rack apps > written with only unicorn in mind. > > Existing `timeout' feature of unicorn is already something I hate > and don't want to encourage further reliance on: > > https://bogomips.org/unicorn/Application_Timeouts.html > > Fwiw, I (with ruby-core) will try to make Timeout in ruby stdlib > have less overhead for 2.6 (or 2.7) so it can benefit more users > than just unicorn. Ditto with various OobGC hacks over the years. > > Thanks.