unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Josh Morrow <jcmorrow@thoughtbot.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@bogomips.org
Subject: Re: SIGWINCH with Forego/Heroku Local
Date: Fri, 9 Dec 2016 09:01:27 -0800	[thread overview]
Message-ID: <CAHdu2E6t+XDUEPc4pQePZCZHxbnPpqyko+6=wq6yf+8iYz=7oQ@mail.gmail.com> (raw)
In-Reply-To: <20161209015536.GA28543@starla>

> (please don't drop the public list/archive address from the Cc:)

Whoops, sorry, my bad.

On Thu, Dec 8, 2016 at 5:55 PM, Eric Wong <e@80x24.org> wrote:
> (please don't drop the public list/archive address from the Cc:)
> Josh Morrow <jcmorrow@thoughtbot.com> wrote:
>> Eric Wong <e@80x24.org> wrote:
>> > Fwiw, we switched to checking stdin last year so SIGWINCH could
>> > be usable with foreman and other process managers:
>> In foreman `$stdin.tty?` returns `true`. In ForeGO it returns `nil` : (.
> `nil` or `false`?  With how unicorn uses it, it doesn't matter,
> but it should really be `false` there based on reading the
> rb_io_isatty function in io.c of the MRI source.
> But anyways, I suspect ForeGO redirects the stdin to /dev/null
> (you can check with lsof); which is totally reasonable for
> running daemons.
> That is why I recommended the before_fork workaround to
> trap(:WINCH, "DEFAULT") to restore the default noop behavior.

      reply	other threads:[~2016-12-09 17:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 17:01 SIGWINCH with Forego/Heroku Local Josh Morrow
2016-12-08 18:40 ` Eric Wong
     [not found]   ` <CAHdu2E6=qv1gmLGbZfrivhX5vVYgMq7cwOpCZ9yvFGTR17Prfw@mail.gmail.com>
2016-12-09  1:55     ` Eric Wong
2016-12-09 17:01       ` Josh Morrow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHdu2E6t+XDUEPc4pQePZCZHxbnPpqyko+6=wq6yf+8iYz=7oQ@mail.gmail.com' \
    --to=jcmorrow@thoughtbot.com \
    --cc=e@80x24.org \
    --cc=unicorn-public@bogomips.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).