unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Aman Gupta <aman@tmm1.net>
To: Eric Wong <e@80x24.org>
Cc: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+
Date: Sat, 29 Mar 2014 14:50:50 -0700	[thread overview]
Message-ID: <CAK=uwuzEc0fGduY6Q3a9h2tmOnTvmTHbU-kTEPSbjTR=w5Cs-g@mail.gmail.com> (raw)
In-Reply-To: <20140329013534.GA10450@dcvr.yhbt.net>

Fine by me.

On Fri, Mar 28, 2014 at 6:35 PM, Eric Wong <e@80x24.org> wrote:
> I've never liked OobGC, so "hot potato!" :)
> ---
>  I'll push this sometime this weekend.
>  Corrections/edits/acks/nacks welcome.
>
>  lib/unicorn/oob_gc.rb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/unicorn/oob_gc.rb b/lib/unicorn/oob_gc.rb
> index 4e78a70..4cddd50 100644
> --- a/lib/unicorn/oob_gc.rb
> +++ b/lib/unicorn/oob_gc.rb
> @@ -1,5 +1,11 @@
>  # -*- encoding: binary -*-
>
> +# Strongly consider https://github.com/tmm1/gctools if using Ruby 2.1+
> +# It is built on new APIs in Ruby 2.1, so it is more intelligent than
> +# this historical implementation.
> +#
> +# The following information is only for historical versions of Ruby.
> +#
>  # Runs GC after requests, after closing the client socket and
>  # before attempting to accept more connections.
>  #
> --
> EW
>
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

  reply	other threads:[~2014-03-29 21:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-29  1:35 [RFC] oobgc: link to Aman's gctools for Ruby 2.1+ Eric Wong
2014-03-29 21:50 ` Aman Gupta [this message]
2014-04-02  4:55 ` Sam Saffron
2014-04-02  9:55   ` Eric Wong
2014-04-02 10:05     ` Sam Saffron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK=uwuzEc0fGduY6Q3a9h2tmOnTvmTHbU-kTEPSbjTR=w5Cs-g@mail.gmail.com' \
    --to=aman@tmm1.net \
    --cc=e@80x24.org \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).