From: Stan Hu <stanhu@gmail.com> To: unicorn-public@yhbt.net Subject: Sustained queuing on one listener can block requests from other listeners Date: Tue, 14 Apr 2020 22:06:15 -0700 Message-ID: <CAMBWrQ=Yh42MPtzJCEO7XryVknDNetRMuA87irWfqVuLdJmiBQ@mail.gmail.com> (raw) My unicorn.rb has two listeners: listen "127.0.0.1:8080", :tcp_nopush => false listen "/var/run/unicorn.socket", :backlog => 1024 We found that because of the greedy attempt to accept new connections before calling select() in https://github.com/defunkt/unicorn/blob/981f561a726bb4307d01e4a09a308edba8d69fe3/lib/unicorn/http_server.rb#L707-L714, listeners on another socket stall out until the first listener is drained. We would expect Unicorn to round-robin between the two listeners, but that doesn't happen as long as there is work to be done for the first listener. We've verified that deleting that `redo` block fixes the problem. What do you think about the various options? 1. Only running that redo block if there is one listener 2. Removing the redo block entirely
next reply other threads:[~2020-04-15 5:06 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-15 5:06 Stan Hu [this message] 2020-04-15 5:26 ` Eric Wong 2020-04-16 5:46 ` Stan Hu 2020-04-16 6:59 ` Eric Wong 2020-04-16 7:24 ` Stan Hu 2020-04-16 9:24 ` [PATCH] prevent single listener from monopolizing a worker Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMBWrQ=Yh42MPtzJCEO7XryVknDNetRMuA87irWfqVuLdJmiBQ@mail.gmail.com' \ --to=stanhu@gmail.com \ --cc=unicorn-public@yhbt.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help This inbox may be cloned and mirrored by anyone: git clone --mirror https://yhbt.net/unicorn-public git clone --mirror http://ou63pmih66umazou.onion/unicorn-public # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 unicorn-public unicorn-public/ https://yhbt.net/unicorn-public \ unicorn-public@yhbt.net unicorn-public@bogomips.org mongrel-unicorn@rubyforge.org mongrel-unicorn-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org public-inbox-index unicorn-public Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: ../../unicorn.git AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git