From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owen.o@heroku.com>
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
 shortcircuit=no autolearn=unavailable version=3.3.2
X-Original-To: unicorn-public@bogomips.org
Received: from mail-yk0-f177.google.com (mail-yk0-f177.google.com
 [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256
 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix)
 with ESMTPS id F0A26203B3 for <unicorn-public@bogomips.org>; Mon, 16 Nov 2015
 23:43:29 +0000 (UTC)
Received: by ykdv3 with SMTP id v3so267696234ykd.0 for
 <unicorn-public@bogomips.org>; Mon, 16 Nov 2015 15:43:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=heroku_com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:date:message-id:subject:from:to:cc:content-type
 :content-transfer-encoding; bh=4COiHnJRShu1HITc9Lj4zSBo/UaTzXxwgj7f40R4Ae4=;
 b=aFrvcV6EMDksowBNg8ccrV3EujAm+VhtAaIznj0Kin7vDqKCnG4cbQ11bL5NbAIa0g
 VK5B5H/ve/9Bk5av9bsX0ZozrDXi+g0jd2GG3Trr5u8VK5EoUM0TpAGr+IfbUEIHb1jm
 GOrora5mFdHLVEj2JOLVo3wfHZXpcUtENrZzBuk8tN8WdRz3APfzRmNMMVlD5ekggthc
 bqZN4qqXUhLuikGReHk4wfwqSjBk7iG7EoHyWsRgRQbxIv5YX+47HHJKva+0FrmVQy08
 ZfUPYZg0ssKuBlr3Cwqd87TzCtaEMOZ0myIic+S7IkUMWrK3zAIb0r4fGSojJFHutke6 55GA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;
 s=20130820;
 h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc
 :content-type:content-transfer-encoding;
 bh=4COiHnJRShu1HITc9Lj4zSBo/UaTzXxwgj7f40R4Ae4=;
 b=BmggE2txNli7CtljqrnzwCLd9yacBXrgQ8a0Y4/isG/TfzI7GD1PFjPrvHBcsmnOOC
 lqpAy81zz8w/zFX76TqxlH//6kbqlbhgKlRTt+2e6gD+H8rZiTHz7HoLlNGpcnWtxQYR
 FKknmfQ/7esxS+LpL2BuLoOL8b63gku6kEC4+LrZek0TnJ84gHGUGBiILqXzJpdIVdJf
 NGgBzn73Z6ds58A8JB58d5GDoTRb+Qq8X7TnxEI2OSdpzQ0TTeWgyEZSuwyaCgDKHYL5
 QlqKO0GDTqPnOWPYqCUnZuY41wkgOZ0IAJUo54hPV0iNklc4mqu582+TrkIv/QNbu/Jh F8/w==
X-Gm-Message-State:
 ALoCoQlMjwA5131dQCeVinK2xIKsBZ8NAUSNEZFSPRRr9om90tnJvBSupEa7aepo96dLqKdAFgU3
MIME-Version: 1.0
X-Received: by 10.129.154.148 with SMTP id
 r142mr42042964ywg.291.1447717409159; Mon, 16 Nov 2015 15:43:29 -0800 (PST)
Received: by 10.37.65.145 with HTTP; Mon, 16 Nov 2015 15:43:29 -0800 (PST)
Date: Mon, 16 Nov 2015 15:43:29 -0800
Message-ID:
 <CAO47=rJa=zRcLn_Xm4v2cHPr6c0UswaFC_omYFEH+baSxHOWKQ@mail.gmail.com>
Subject: undefined method `include?' for nil:NilClass (NoMethodError)
From: Owen Ou <o@heroku.com>
To: unicorn-public@bogomips.org
Cc: api-team <api-team@heroku.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <unicorn-public@bogomips.org>

Hi,


We recently upgraded to Unicorn 5.0 but getting the following error:


[2015-11-16T14:54:16.943652 #19838] ERROR -- : app error: undefined
method `include?' for nil:NilClass (NoMethodError)

E, [2015-11-16T14:54:16.943712 #19838] ERROR -- :
/home/api/vendor/bundle/ruby/2.2.0/gems/unicorn-5.0.0/lib/unicorn/http_resp=
onse.rb:40:in
`block in http_response_write'

E, [2015-11-16T14:54:16.943737 #19838] ERROR -- :
/home/api/vendor/bundle/ruby/2.2.0/gems/rack-1.6.4/lib/rack/utils.rb:490:in
`block in each'

E, [2015-11-16T14:54:16.943753 #19838] ERROR -- :
/home/api/vendor/bundle/ruby/2.2.0/gems/rack-1.6.4/lib/rack/utils.rb:489:in
`each'

E, [2015-11-16T14:54:16.943767 #19838] ERROR -- :
/home/api/vendor/bundle/ruby/2.2.0/gems/rack-1.6.4/lib/rack/utils.rb:489:in
`each=E2=80=99


The error came from this commit:
https://github.com/defunkt/unicorn/commit/fb2f10e1d7a72e6787720003342a21f11=
b879614.
And specifically the line of `if value =3D~ /\n/` is changed to `if
value.include?("\n".freeze)`. Apparently `value` can be nil which
caused our issue. It should be an easy fix.


Thanks,

Owen