From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dbussink@github.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
	SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham
	autolearn_force=no version=3.4.2
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 812581F9FE
	for <unicorn-public@yhbt.net>; Tue, 16 Mar 2021 10:15:59 +0000 (UTC)
Received: by mail-lj1-x236.google.com with SMTP id y1so19741390ljm.10
        for <unicorn-public@yhbt.net>; Tue, 16 Mar 2021 03:15:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=github.com; s=google;
        h=mime-version:subject:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to;
        bh=r5/+cPDDmfXf1bWxj4ytTHc6VhQW92mujPjupi8ludw=;
        b=bnp36hUzW/8tK4FkxxgoJCiS05tI9kJGNGrM5fIY1DZyYdgAm9BUgY5PaANe0xIlGr
         raFA72wzVR6fqGeLyD+5xZYW8eRl8l/4rkNt8hloR1Zk8dmFtyvsd7srbvTlK3VfeftL
         tAW5kFrp7ChGZ/0+jeLaTni5a5U4uSCjAQ5081fjvVyUOaviAVPH+55AjLCmDK8ey12H
         EiTlo/bjKrJXr9DYemG5MxDoGcz/uLRrcK22DIEQk8lHDesgASm88xMH8+dtYgZ7gJ8N
         OidCUz5WKWezicjXjIS4ujb83+G/be601rGDYHd9nKDBVLjfVSifheBHjhvbmCQmziJQ
         QX1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
         :content-transfer-encoding:message-id:references:to;
        bh=r5/+cPDDmfXf1bWxj4ytTHc6VhQW92mujPjupi8ludw=;
        b=ijtCn5i2I5BgKCdvyOGP6WCCMMSu/ZZG2vtYUx2Fg5dwjdmXgdmSuksKqiKVfU0IJp
         Lu7WkyByqYw3oGVVNVDjntsIOcBSx58sxYKuRPVm/9niuvqTb0i5oUm3P7bvlKG9dFAn
         tOVFY55qnEsPsvvSDmpbe/RCmkVrzMukYnhJ+1IwcAgMZ+o/r55om0Twub2f3q2+I9Qj
         H5QxzbfpUQTTQg6eM95sxM0DdpP8If17bJS/Rwzk3WxqOMX79uF/5vwONmB/OF3nPgjZ
         GxqTu6gpCPaJQOZHz/q7RN5nXjdhKGsiiR6HZdB7A6eJs/XakUulrKYaw0CMdYtICEEY
         gWUw==
X-Gm-Message-State: AOAM530ZdusV2gvrwn54X6t0WiVoWLk0h14LmkAag5j/uuxX5Oys1UuZ
	NF10EFuVVYrtRl/5xqHzArtZdw==
X-Google-Smtp-Source: ABdhPJwHvCjHnl6tPS9vjKTIEdyGHF863s3xP8M8OaIrFXukNcNF5hTtah+Wf1JgmwiSz2KC/L9l4g==
X-Received: by 2002:a05:651c:d0:: with SMTP id 16mr2286397ljr.296.1615889756025;
        Tue, 16 Mar 2021 03:15:56 -0700 (PDT)
Received: from dbussink.archimedes.bussink.me (178-85-12-131.dynamic.upc.nl. [178.85.12.131])
        by smtp.gmail.com with ESMTPSA id r124sm3006001lff.59.2021.03.16.03.15.54
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 16 Mar 2021 03:15:55 -0700 (PDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: Potential Unicorn vulnerability
From: Dirkjan Bussink <dbussink@github.com>
In-Reply-To: <20210313022615.GA32198@dcvr>
Date: Tue, 16 Mar 2021 11:15:53 +0100
Cc: John Crepezzi <seejohnrun@github.com>,
 Kevin Sawicki <kevinsawicki@github.com>,
 unicorn-public@yhbt.net
Content-Transfer-Encoding: quoted-printable
Message-Id: <F17132F5-2035-4396-985C-0043BF615C21@github.com>
References: <F6712BF3-A4DD-41EE-8252-B9799B35E618@github.com>
 <20210311030250.GA1266@dcvr>
 <7F6FD017-7802-4871-88A3-1E03D26D967C@github.com>
 <20210312094129.GA14538@dcvr>
 <382B893C-A07C-4705-950E-6D1CA766D998@github.com>
 <20210312120007.GA24539@dcvr>
 <66A68DD8-83EF-4C7A-80E8-3F1F7AB31670@github.com>
 <20210313022615.GA32198@dcvr>
To: Eric Wong <normalperson@yhbt.net>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
List-Id: <unicorn-public.yhbt.net>

Hello Eric,

> On 13 Mar 2021, at 03:26, Eric Wong <normalperson@yhbt.net> wrote:
>=20
> Anyways, I've squashed the test removal, OobGC adjustment, and
> your 2nd patch together as commit =
c917ac526df214611ec33c21de2b070452ec8434
> and pushed it out as the "v6-wip" branch.

We=E2=80=99ve updated to the v6-wip branch on our side and everything =
looks good with
that branch as well in production. Performance etc. also all looks =
healthy
as well.

Cheers,

Dirkjan