From: Blake Williams <firstname.lastname@example.org> To: Eric Wong <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Add rack.after_reply functionality Date: Wed, 9 Dec 2020 09:58:48 -0500 [thread overview] Message-ID: <F8937548-A781-4C89-8676-B74ACC93E946@blakewilliams.me> (raw) In-Reply-To: <20201209094344.GA25593@dcvr> > OK. Keep in mind this can be server-dependent since unicorn > can't support persistent connections while (most?) other servers > do (and they may disable TCP_CORK or Nagle, etc). I see, I’ll look into this as well. >>> Citation(s) needed. Also, are there any proposal(s) to get this >>> into the Rack specification? >> >> Not that I’m aware of. But I agree that it and early_hints could both be >> good additions to the spec. > > By "Citation(s) needed", can you list some other (preferably > well-known) Rack servers which also implement this feature? > > We wouldn't want current unicorn users thinking we're adopting > random new things which nobody else supports :> > > Thanks. Totally understood. I looked at Puma, Thin, and Webrick and only Puma supports this functionality without a third-party gem. There is at least one third party gem adding this functionality to web servers that don’t support it, but it doesn’t look like it’s being maintained any longer. I briefly dove into the Puma source and it looks like rack.after_reply has been supported since 2011. It’s also still in use by Puma for their common logger middleware patch.
next prev parent reply other threads:[~2020-12-09 14:58 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-08 21:47 Blake Williams 2020-12-08 22:46 ` Eric Wong 2020-12-08 23:48 ` Blake Williams 2020-12-09 9:43 ` Eric Wong 2020-12-09 14:58 ` Blake Williams [this message] 2020-12-09 22:18 ` Eric Wong 2020-12-09 23:44 ` Blake Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F8937548-A781-4C89-8676-B74ACC93E946@blakewilliams.me \ --email@example.com \ --cc=20201209094344.GA25593@dcvr \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Add rack.after_reply functionality' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../unicorn.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).