From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Mon, 7 Sep 2020 09:13:03 +0200 [thread overview]
Message-ID: <FE6CD4B9-858E-4C10-BF53-262DF66CC488@shopify.com> (raw)
In-Reply-To: <20200906093038.GA25772@dcvr>
>> Ok, so the linking issues were simply me being silly. I forgot
>> to run `make ragel` and commit the output (to use a git gem).
>> Unicorn now run just fine under 3.0.0-dev (current master).
>
> Odd, just "make" (no args) should work.
It does, but the files it generates are in .gitignore, and I was
trying to use the gem through bundler's git gems. Anyway,
now I know the drill.
> Anything else in the ruby 3.0 pipeline that might introduce
> incompatibilities?
Not that I know of. There not any big breaking change
planned for 3.0.
> Not sure if releasing unicorn 5.7 is worth doing soon/now or
> closer to December 25...
It is up to you. But the sooner the better for me. We run
our master branch CI against ruby master on a nightly
basis. Until this patch is released I'll have to keep a fork
around.
next prev parent reply other threads:[~2020-09-07 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04 ` Jean Boussier
2020-09-01 15:41 ` Eric Wong
2020-09-03 7:52 ` Jean Boussier
2020-09-03 8:25 ` Eric Wong
2020-09-03 8:29 ` Jean Boussier
2020-09-03 9:31 ` Eric Wong
2020-09-03 11:23 ` Jean Boussier
2020-09-04 12:34 ` Jean Boussier
2020-09-06 9:30 ` Eric Wong
2020-09-07 7:13 ` Jean Boussier [this message]
2020-09-08 2:24 ` Eric Wong
2020-09-08 8:00 ` Jean Boussier
2020-09-08 8:50 ` Eric Wong
2020-09-08 8:56 ` Jean Boussier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FE6CD4B9-858E-4C10-BF53-262DF66CC488@shopify.com \
--to=jean.boussier@shopify.com \
--cc=e@80x24.org \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).