From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@80x24.org>, Martin Posthumus <martin.posthumus@gmail.com>
Cc: unicorn-public@yhbt.net
Subject: Re: Support for Rack 3 headers formatted as arrays
Date: Wed, 11 Jan 2023 12:12:07 +0100 [thread overview]
Message-ID: <f79ea4aa-421e-4c63-c704-efe2d5fd03cb@shopify.com> (raw)
In-Reply-To: <20221225225658.M711750@dcvr>
Interestingly, this patch would also help with Ruby 3.2 compatibility.
Ruby 3.2 removed `Kernel#=~`, so when misbehaving app return header
values in e.g. Integer
unicorn now choke on it:
app error: undefined method `=~' for 43747171631368:Integer (NoMethodError)
unicorn-6.1.0/lib/unicorn/http_response.rb:43:in `block in
http_response_write'
unicorn-6.1.0/lib/unicorn/http_response.rb:34:in `each'
unicorn-6.1.0/lib/unicorn/http_response.rb:34:in `http_response_write'
unicorn-6.1.0/lib/unicorn/http_server.rb:645:in `process_client'
Whereas on 3.1 and older, `42 =~ /\n/` would simply not match and cast
the header as a String.
next prev parent reply other threads:[~2023-01-11 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 21:52 Support for Rack 3 headers formatted as arrays Martin Posthumus
2022-12-10 2:42 ` Eric Wong
2022-12-12 15:52 ` Martin Posthumus
2022-12-25 22:56 ` Eric Wong
2022-12-27 8:17 ` Jean Boussier
2023-01-11 11:12 ` Jean Boussier [this message]
2023-01-11 11:40 ` Eric Wong
2023-01-11 11:44 ` Jean Boussier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79ea4aa-421e-4c63-c704-efe2d5fd03cb@shopify.com \
--to=jean.boussier@shopify.com \
--cc=e@80x24.org \
--cc=martin.posthumus@gmail.com \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).