diff options
author | Eric Wong <e@80x24.org> | 2014-05-25 04:40:20 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2014-05-29 20:12:04 +0000 |
commit | 5bd61b57d63ae86fc246531d3a483c15ee0dcd57 (patch) | |
tree | 9810d265992167770f426a25c003ed362cc25771 /t | |
parent | 9f72638e08d7d08eadffe6b0299205b6620f250e (diff) | |
download | unicorn-5bd61b57d63ae86fc246531d3a483c15ee0dcd57.tar.gz |
This has long been considered a mistake and not documented for very long. I considered removing X-Forwarded-Proto and X-Forwarded-SSL handling, too, so rack.url_scheme is always "http", but that might lead to compatibility issues in rare apps if Rack::Request#scheme is not used.
Diffstat (limited to 't')
-rwxr-xr-x | t/t0016-trust-x-forwarded-false.sh | 30 | ||||
-rwxr-xr-x | t/t0017-trust-x-forwarded-true.sh | 30 |
2 files changed, 0 insertions, 60 deletions
diff --git a/t/t0016-trust-x-forwarded-false.sh b/t/t0016-trust-x-forwarded-false.sh deleted file mode 100755 index 3163690..0000000 --- a/t/t0016-trust-x-forwarded-false.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/bin/sh -. ./test-lib.sh -t_plan 5 "trust_x_forwarded=false configuration test" - -t_begin "setup and start" && { - unicorn_setup - echo "trust_x_forwarded false" >> $unicorn_config - unicorn -D -c $unicorn_config env.ru - unicorn_wait_start -} - -t_begin "spoofed request with X-Forwarded-Proto does not trigger" && { - curl -H 'X-Forwarded-Proto: https' http://$listen/ | \ - grep -F '"rack.url_scheme"=>"http"' -} - -t_begin "spoofed request with X-Forwarded-SSL does not trigger" && { - curl -H 'X-Forwarded-SSL: on' http://$listen/ | \ - grep -F '"rack.url_scheme"=>"http"' -} - -t_begin "killing succeeds" && { - kill $unicorn_pid -} - -t_begin "check stderr has no errors" && { - check_stderr -} - -t_done diff --git a/t/t0017-trust-x-forwarded-true.sh b/t/t0017-trust-x-forwarded-true.sh deleted file mode 100755 index 11103c5..0000000 --- a/t/t0017-trust-x-forwarded-true.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/bin/sh -. ./test-lib.sh -t_plan 5 "trust_x_forwarded=true configuration test" - -t_begin "setup and start" && { - unicorn_setup - echo "trust_x_forwarded true " >> $unicorn_config - unicorn -D -c $unicorn_config env.ru - unicorn_wait_start -} - -t_begin "spoofed request with X-Forwarded-Proto sets 'https'" && { - curl -H 'X-Forwarded-Proto: https' http://$listen/ | \ - grep -F '"rack.url_scheme"=>"https"' -} - -t_begin "spoofed request with X-Forwarded-SSL sets 'https'" && { - curl -H 'X-Forwarded-SSL: on' http://$listen/ | \ - grep -F '"rack.url_scheme"=>"https"' -} - -t_begin "killing succeeds" && { - kill $unicorn_pid -} - -t_begin "check stderr has no errors" && { - check_stderr -} - -t_done |