about summary refs log tree commit homepage
path: root/test
diff options
context:
space:
mode:
authorEric Wong <normalperson@yhbt.net>2009-10-01 13:21:57 -0700
committerEric Wong <normalperson@yhbt.net>2009-10-01 13:21:57 -0700
commiteb619c04765ef31b0e88329cbfd138d24558776e (patch)
tree0c3e8f8c3b5ef9b39c0c164027b5e15e9ba46254 /test
parent9dcbd1387c4c23c84f5a733b6e2e2839b239bdac (diff)
downloadunicorn-eb619c04765ef31b0e88329cbfd138d24558776e.tar.gz
There's always been a small window of opportunity for a script
to do File.read(pid).to_i would cause File.read() to read an
empty file and return "".  This closes that window while
hopefully retaining backwards compatibility...

We've always checked for dirname(pid) writability in
Configurator, so we can safely write to a temporary file in the
intended directory and then atomically rename() it to the
destination path.
Diffstat (limited to 'test')
-rw-r--r--test/exec/test_exec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/exec/test_exec.rb b/test/exec/test_exec.rb
index e753c2d..268a84e 100644
--- a/test/exec/test_exec.rb
+++ b/test/exec/test_exec.rb
@@ -728,7 +728,7 @@ end
       }
     }
     sleep 1 # racy
-    daemon_pid = pid_file.read.to_i
+    daemon_pid = File.read(pid_file.path).to_i
     assert daemon_pid > 0
     Process.kill(:HUP, daemon_pid)
     sleep 1 # racy