From 5fba71ea0821beeb922b4da763ab58abc1c954c4 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 2 Mar 2015 21:03:59 +0000 Subject: socket_helper: update comments We had HTTPS support but dropped it(*) and some wacky servers out there do work better with TCP_DEFER_ACCEPT disabled. (*) No, we will not support HTTP/2, that is for nginx --- lib/unicorn/socket_helper.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/unicorn/socket_helper.rb b/lib/unicorn/socket_helper.rb index a4247ac..a321ddf 100644 --- a/lib/unicorn/socket_helper.rb +++ b/lib/unicorn/socket_helper.rb @@ -16,7 +16,7 @@ module Unicorn :tcp_defer_accept => 1, # FreeBSD, we need to override this to 'dataready' if we - # eventually get HTTPS support + # eventually support non-HTTP/1.x :accept_filter => 'httpready', # same default value as Mongrel @@ -53,8 +53,8 @@ module Unicorn end end - # No good reason to ever have deferred accepts off - # (except maybe benchmarking) + # No good reason to ever have deferred accepts off in single-threaded + # servers (except maybe benchmarking) if Socket.const_defined?(:TCP_DEFER_ACCEPT) # this differs from nginx, since nginx doesn't allow us to # configure the the timeout... -- cgit v1.2.3-24-ge0c7