From 7e36e29a69c4adb777e82a91a381bd680967c055 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 29 Jun 2009 21:24:59 -0700 Subject: Only send "100 Continue" when no body has been sent Under slow/inconsistent network conditions or overly aggressive clients, there is a possibility we could've already started reading the body. In those cases, don't bother responding to the expectation to continue since the client has already started sending a message body. --- lib/unicorn/http_request.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/unicorn/http_request.rb b/lib/unicorn/http_request.rb index 553c3df..d2fdac8 100644 --- a/lib/unicorn/http_request.rb +++ b/lib/unicorn/http_request.rb @@ -88,10 +88,10 @@ module Unicorn # Handles dealing with the rest of the request # returns a Rack environment if successful def handle_body(socket) - if /\A100-continue\z/i =~ PARAMS[Const::HTTP_EXPECT] - socket.write(Const::EXPECT_100_RESPONSE) - end PARAMS[Const::RACK_INPUT] = if (body = PARAMS.delete(:http_body)) + if 0 == body.size && /\A100-continue\z/i =~ PARAMS[Const::HTTP_EXPECT] + socket.write(Const::EXPECT_100_RESPONSE) + end length = PARAMS[Const::CONTENT_LENGTH].to_i if te = PARAMS[Const::HTTP_TRANSFER_ENCODING] -- cgit v1.2.3-24-ge0c7