From afde9a73a0eafb9c52b3d4ce2911692924ea626e Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 17 Mar 2016 00:27:36 +0000 Subject: doc: reference --keep-file-descriptors for "bundle exec" "bundle exec" alone is not suitable for use with systemd-style socket activation due to Ruby 2.0+ behavior of setting close-on-exec for file descriptors above 2. However, the "--keep-file-descriptors" option was added to bundler 1.4.0 to workaround this Ruby 2.0 change and may be used to prevent Ruby 2.0+ from closing file descriptors on exec. Thanks to Amir Yalon and Christos Trochalakis for bringing up this issue on the mailing list: http://bogomips.org/unicorn-public/1457824748.3666627.547425122.2A828B07@webmail.messagingengine.com/ --- Sandbox | 6 +++--- examples/unicorn@.service | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Sandbox b/Sandbox index 997b92f..0760065 100644 --- a/Sandbox +++ b/Sandbox @@ -63,9 +63,9 @@ before_exec hook as illustrated by https://gist.github.com/534668 === Ruby 2.0.0 close-on-exec and SIGUSR2 incompatibility Ruby 2.0.0 enforces FD_CLOEXEC on file descriptors by default. unicorn -has been prepared for this behavior since unicorn 4.1.0, but we forgot -to remind the Bundler developers. This issue is being tracked here: -https://github.com/bundler/bundler/issues/2628 +has been prepared for this behavior since unicorn 4.1.0, and bundler +needs the "--keep-file-descriptors" option for "bundle exec": +http://bundler.io/man/bundle-exec.1.html == Isolate diff --git a/examples/unicorn@.service b/examples/unicorn@.service index b058da5..56aaec8 100644 --- a/examples/unicorn@.service +++ b/examples/unicorn@.service @@ -11,6 +11,8 @@ Wants = unicorn.socket After = unicorn.socket [Service] +# bundler users must use the "--keep-file-descriptors" switch, here: +# ExecStart = bundle exec --keep-file-descriptors unicorn -c ... ExecStart = /usr/bin/unicorn -c /path/to/unicorn.conf.rb /path/to/config.ru Sockets = unicorn.socket KillSignal = SIGQUIT -- cgit v1.2.3-24-ge0c7