From 4347b8987732b5bea83ddb8fb9605cf2c4a1c2fe Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 18 Feb 2010 18:44:38 -0800 Subject: http: avoid signedness warnings We never come close to the signed limits anywhere, so it should be safe either way, but make paranoid compiler settings less noisy if possible. --- ext/unicorn_http/common_field_optimization.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'ext/unicorn_http/common_field_optimization.h') diff --git a/ext/unicorn_http/common_field_optimization.h b/ext/unicorn_http/common_field_optimization.h index 850fb90..42c5430 100644 --- a/ext/unicorn_http/common_field_optimization.h +++ b/ext/unicorn_http/common_field_optimization.h @@ -67,7 +67,7 @@ static void init_common_fields(void) char tmp[64]; memcpy(tmp, HTTP_PREFIX, HTTP_PREFIX_LEN); - for(i = 0; i < ARRAY_SIZE(common_http_fields); cf++, i++) { + for(i = ARRAY_SIZE(common_http_fields); --i >= 0; cf++) { /* Rack doesn't like certain headers prefixed with "HTTP_" */ if (!strcmp("CONTENT_LENGTH", cf->name) || !strcmp("CONTENT_TYPE", cf->name)) { @@ -87,8 +87,8 @@ static VALUE find_common_field(const char *field, size_t flen) int i; struct common_field *cf = common_http_fields; - for(i = 0; i < ARRAY_SIZE(common_http_fields); i++, cf++) { - if (cf->len == flen && !memcmp(cf->name, field, flen)) + for(i = ARRAY_SIZE(common_http_fields); --i >= 0; cf++) { + if (cf->len == (long)flen && !memcmp(cf->name, field, flen)) return cf->value; } return Qnil; -- cgit v1.2.3-24-ge0c7