From 93e154e16b87f943a20fa720e002c67c9d17c30b Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 30 Apr 2021 18:17:33 +0000 Subject: test_util: less excessive encoding tests Ruby's handling of encodings hasn't changed much in over a decade and these tests haven't failed for me since August 2013: https://yhbt.net/unicorn-public/9af083d7f6b97c0f5ebbdd9a42b58478a6f874b7/s/ So lets take a small step in reducing energy consumption and save potential developers over 10s of CPU time. --- test/unit/test_util.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/unit/test_util.rb b/test/unit/test_util.rb index 4a820ea..bc7b233 100644 --- a/test/unit/test_util.rb +++ b/test/unit/test_util.rb @@ -51,7 +51,7 @@ class TestUtil < Test::Unit::TestCase def test_reopen_logs_renamed_with_encoding tmp = Tempfile.new('') tmp_path = tmp.path.dup.freeze - Encoding.list.each { |encoding| + Encoding.list.sample(5).each { |encoding| File.open(tmp_path, "a:#{encoding.to_s}") { |fp| fp.sync = true assert_equal encoding, fp.external_encoding @@ -74,8 +74,9 @@ class TestUtil < Test::Unit::TestCase def test_reopen_logs_renamed_with_internal_encoding tmp = Tempfile.new('') tmp_path = tmp.path.dup.freeze - Encoding.list.each { |ext| - Encoding.list.each { |int| + full = Encoding.list + full.sample(2).each { |ext| + full.sample(2).each { |int| next if ext == int File.open(tmp_path, "a:#{ext.to_s}:#{int.to_s}") { |fp| fp.sync = true -- cgit v1.2.3-24-ge0c7