From f3b379f938719ed7cdfdf2eb92491db276e2da07 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 14 Aug 2009 21:03:39 -0700 Subject: http_request: reinstate empty StringIO optimization This makes a noticeable difference on light GET/HEAD requests. Heck, even the tests run a few seconds faster. --- test/unit/test_request.rb | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'test') diff --git a/test/unit/test_request.rb b/test/unit/test_request.rb index 139fc82..edd4c55 100644 --- a/test/unit/test_request.rb +++ b/test/unit/test_request.rb @@ -120,6 +120,31 @@ class RequestTest < Test::Unit::TestCase assert_nothing_raised { res = @lint.call(env) } end + def test_no_content_stringio + client = MockRequest.new("GET / HTTP/1.1\r\nHost: foo\r\n\r\n") + res = env = nil + assert_nothing_raised { env = @request.read(client) } + assert_equal StringIO, env['rack.input'].class + end + + def test_zero_content_stringio + client = MockRequest.new("PUT / HTTP/1.1\r\n" \ + "Content-Length: 0\r\n" \ + "Host: foo\r\n\r\n") + res = env = nil + assert_nothing_raised { env = @request.read(client) } + assert_equal StringIO, env['rack.input'].class + end + + def test_real_content_not_stringio + client = MockRequest.new("PUT / HTTP/1.1\r\n" \ + "Content-Length: 1\r\n" \ + "Host: foo\r\n\r\n") + res = env = nil + assert_nothing_raised { env = @request.read(client) } + assert_equal Unicorn::TeeInput, env['rack.input'].class + end + def test_rack_lint_put client = MockRequest.new( "PUT / HTTP/1.1\r\n" \ -- cgit v1.2.3-24-ge0c7