From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] extras/autoindex: do not link beyond top-level
Date: Mon, 1 Sep 2014 22:48:06 +0000 [thread overview]
Message-ID: <1409611686-19284-1-git-send-email-e@80x24.org> (raw)
No need to waste space on this (and trigger "Bad partial
reference!" warnings on lynx)
---
| 2 ++
| 6 +++++-
2 files changed, 7 insertions(+), 1 deletion(-)
--git a/extras/autoindex.rb b/extras/autoindex.rb
index c8f7054..0ae7260 100644
--- a/extras/autoindex.rb
+++ b/extras/autoindex.rb
@@ -71,6 +71,8 @@ class Autoindex
case base
when "."
next
+ when ".."
+ next if path_info == "/"
end
begin
--git a/test/test_extras_autoindex.rb b/test/test_extras_autoindex.rb
index ed0e1d5..e17234f 100644
--- a/test/test_extras_autoindex.rb
+++ b/test/test_extras_autoindex.rb
@@ -44,8 +44,12 @@ class TestExtrasAutoindex < Testcase
res = http.request(Net::HTTP::Get.new("/"))
assert_equal 200, res.code.to_i
+ refute_match %r{\.\./}, res.body, "top level should not link to parent"
assert_match %r{foo}, res.body
- assert_match %r{bar/}, res.body
+
+ res = http.request(Net::HTTP::Get.new("/bar/"))
+ assert_equal 200, res.code.to_i
+ assert_match %r{\.\./}, res.body, "link to parent present"
end
ensure
quit_wait pid
--
EW
reply other threads:[~2014-09-01 22:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409611686-19284-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).