From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 71D0A1F7B0; Thu, 20 Nov 2014 20:45:51 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Cc: e@80x24.org Subject: [PATCH 2/6] remove unused client_max_header_size config Date: Thu, 20 Nov 2014 20:45:38 +0000 Message-Id: <1416516342-18987-3-git-send-email-e@80x24.org> X-Mailer: git-send-email 2.2.0.rc0.dirty In-Reply-To: <1416516342-18987-1-git-send-email-e@80x24.org> References: <1416516342-18987-1-git-send-email-e@80x24.org> List-Id: We may not be able to support this in a more performant way just yet. Since this was never documented, we'll remove the the current knobs for silently setting and ignoring it. Users should use Unicorn::HttpParser.max_header_len= for now, instead. We may change Unicorn::HttpParser in the future if enough people care about making this functionality per-app. --- lib/yahns/config.rb | 1 - lib/yahns/http_context.rb | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb index 4ea51af..3055539 100644 --- a/lib/yahns/config.rb +++ b/lib/yahns/config.rb @@ -363,7 +363,6 @@ class Yahns::Config # :nodoc: # config name, minimum value client_body_buffer_size: 1, client_header_buffer_size: 1, - client_max_header_size: 1, }.each do |_v,minval| eval( %Q(def #{_v}(val);) << diff --git a/lib/yahns/http_context.rb b/lib/yahns/http_context.rb index 349e129..73bb49a 100644 --- a/lib/yahns/http_context.rb +++ b/lib/yahns/http_context.rb @@ -9,7 +9,6 @@ module Yahns::HttpContext # :nodoc: attr_accessor :client_body_buffer_size attr_accessor :client_header_buffer_size attr_accessor :client_max_body_size - attr_accessor :client_max_header_size attr_accessor :input_buffering # :lazy, true, false attr_accessor :output_buffering # true, false attr_accessor :persistent_connections # true or false only -- EW