yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: e@80x24.org
Subject: [PATCH 5/6] favor Array#map! for freshly-split arrays
Date: Thu, 20 Nov 2014 20:45:41 +0000	[thread overview]
Message-ID: <1416516342-18987-6-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1416516342-18987-1-git-send-email-e@80x24.org>

This barely reduces garbage objects at startup, but less
garbage is usually better.
 lib/yahns/server.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/yahns/server.rb b/lib/yahns/server.rb
index b28e741..1196d2d 100644
--- a/lib/yahns/server.rb
+++ b/lib/yahns/server.rb
@@ -313,7 +313,7 @@ class Yahns::Server # :nodoc:
     # because that can completely break the non-blocking one.
     # Unfortunately, there is no one-off MSG_DONTWAIT-like flag for
     # accept4(2).
-    inherited = ENV['YAHNS_FD'].to_s.split(',').map do |fd|
+    inherited = ENV['YAHNS_FD'].to_s.split(',').map! do |fd|
       io = Socket.for_fd(fd.to_i)
       set_server_sockopt(io, sock_opts(io))
       @logger.info "inherited addr=#{sock_name(io)} fd=#{fd}"

  parent reply	other threads:[~2014-11-20 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 20:45 [PATCH 0/6] misc minor updates Eric Wong
2014-11-20 20:45 ` [PATCH 1/6] http_response: remove arg for Array#join Eric Wong
2014-11-20 20:45 ` [PATCH 2/6] remove unused client_max_header_size config Eric Wong
2014-11-20 20:45 ` [PATCH 3/6] config: use literal symbol array for now Eric Wong
2014-11-20 20:45 ` [PATCH 4/6] http_response: reduce constants for 100 responses Eric Wong
2014-11-20 20:45 ` Eric Wong [this message]
2014-11-20 20:45 ` [PATCH 6/6] sendfile_compat: remove dependency on pread Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416516342-18987-6-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).