yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] test/test_server: fix leftover process from inherit test
@ 2015-03-09 10:04 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-03-09 10:04 UTC (permalink / raw)
  To: yahns-public

Oops, this test bug was introduced in:
commit e413325737f23c5ec27a02246f95077bc1fb038d
("acceptor: close inherited-but-unneeded sockets")
---
 test/test_server.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/test_server.rb b/test/test_server.rb
index b7cb3e6..0410f65 100644
--- a/test/test_server.rb
+++ b/test/test_server.rb
@@ -815,7 +815,7 @@ class TestServer < Testcase
       GTL.synchronize { app(:rack, ru) { listen "#{host}:#{port}" } }
       logger(Logger.new(err.path))
     end
-    mkserver(cfg, @srv) do
+    pid = mkserver(cfg, @srv) do
       s2.autoclose = false
       ENV["YAHNS_FD"] = "#{@srv.fileno},#{s2.fileno}"
     end
@@ -842,5 +842,7 @@ class TestServer < Testcase
     assert_nil a2.read(1)
     a2.close
     s2.close
+  ensure
+    quit_wait(pid)
   end
 end
-- 
2.3.1.170.ge0b4cad


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-03-09 10:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 10:04 [PATCH] test/test_server: fix leftover process from inherit test Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).