yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] extras/proxy_pass: remove ERROR_502 constant
Date: Fri, 13 Mar 2015 01:03:22 +0000	[thread overview]
Message-ID: <1426208602-22883-1-git-send-email-e@80x24.org> (raw)

Some middlewares may attempt to modify the response body in
place, so sharing this is not a good idea.  We shouldn't
really care about rare 502 error paths, either.
---
 extras/proxy_pass.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/extras/proxy_pass.rb b/extras/proxy_pass.rb
index ac01c34..08f9730 100644
--- a/extras/proxy_pass.rb
+++ b/extras/proxy_pass.rb
@@ -16,8 +16,6 @@ require 'timeout'
 # cheap on GNU/Linux...
 # This is totally untested but currently doesn't serve anything important.
 class ProxyPass # :nodoc:
-  ERROR_502 = [ 502, {'Content-Length'=>'0','Content-Type'=>'text/plain'}, [] ]
-
   class ConnPool
     def initialize
       @mtx = Mutex.new
@@ -187,7 +185,7 @@ class ProxyPass # :nodoc:
       logger = env['rack.logger'] and
         Yahns::Log.exception(logger, 'proxy_pass', e)
     end
-    ERROR_502
+    [ 502, [ %w(Content-Length 0), %w(Content-Type text/plain) ], [] ]
   end
 
   def send_body(input, ures, chunked)
-- 
EW


                 reply	other threads:[~2015-03-13  1:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426208602-22883-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).