yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] extras/proxy_pass: remove ERROR_502 constant
@ 2015-03-13  1:03 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-03-13  1:03 UTC (permalink / raw)
  To: yahns-public

Some middlewares may attempt to modify the response body in
place, so sharing this is not a good idea.  We shouldn't
really care about rare 502 error paths, either.
---
 extras/proxy_pass.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/extras/proxy_pass.rb b/extras/proxy_pass.rb
index ac01c34..08f9730 100644
--- a/extras/proxy_pass.rb
+++ b/extras/proxy_pass.rb
@@ -16,8 +16,6 @@ require 'timeout'
 # cheap on GNU/Linux...
 # This is totally untested but currently doesn't serve anything important.
 class ProxyPass # :nodoc:
-  ERROR_502 = [ 502, {'Content-Length'=>'0','Content-Type'=>'text/plain'}, [] ]
-
   class ConnPool
     def initialize
       @mtx = Mutex.new
@@ -187,7 +185,7 @@ class ProxyPass # :nodoc:
       logger = env['rack.logger'] and
         Yahns::Log.exception(logger, 'proxy_pass', e)
     end
-    ERROR_502
+    [ 502, [ %w(Content-Length 0), %w(Content-Type text/plain) ], [] ]
   end
 
   def send_body(input, ures, chunked)
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-03-13  1:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13  1:03 [PATCH] extras/proxy_pass: remove ERROR_502 constant Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).