From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] avoid unnecessary calls #to_sym for __send__
Date: Fri, 13 Mar 2015 01:36:10 +0000 [thread overview]
Message-ID: <1426210570-6833-1-git-send-email-e@80x24.org> (raw)
No point in bloating our bytecode for single-use variables.
---
| 2 +-
lib/yahns/rackup_handler.rb | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--git a/extras/proxy_pass.rb b/extras/proxy_pass.rb
index 08f9730..15cbae5 100644
--- a/extras/proxy_pass.rb
+++ b/extras/proxy_pass.rb
@@ -134,7 +134,7 @@ class ProxyPass # :nodoc:
def call(env)
request_method = env['REQUEST_METHOD']
req = Rack::Request.new(env)
- path = @path.gsub(/\$(\w+)/) { req.__send__($1.to_sym) }
+ path = @path.gsub(/\$(\w+)/) { req.__send__($1) }
req = "#{request_method} #{path} HTTP/1.1\r\n" \
"X-Forwarded-For: #{env["REMOTE_ADDR"]}\r\n"
diff --git a/lib/yahns/rackup_handler.rb b/lib/yahns/rackup_handler.rb
index 127db48..3d7beab 100644
--- a/lib/yahns/rackup_handler.rb
+++ b/lib/yahns/rackup_handler.rb
@@ -32,7 +32,6 @@ module Yahns::RackupHandler # :nodoc:
end
%w(stderr_path stdout_path).each do |x|
- x = x.to_sym
val = o[x] and __send__(x, val)
end
end
--
EW
reply other threads:[~2015-03-13 1:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426210570-6833-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).