yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] proxy_pass: capture local variable earlier for rescue
Date: Thu,  9 Apr 2015 22:21:10 +0000	[thread overview]
Message-ID: <1428618070-17994-1-git-send-email-e@80x24.org> (raw)

This giant method needs to spew an error response in case uploads
to the upstream fail, ensure the local variable is defined early.
---
 lib/yahns/proxy_pass.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb
index 1b8eed7..d02bb40 100644
--- a/lib/yahns/proxy_pass.rb
+++ b/lib/yahns/proxy_pass.rb
@@ -28,10 +28,10 @@ def detach_rbuf!
     end
 
     def yahns_step # yahns event loop entry point
+      c = @yahns_client
       case req = @rrstate
       when Kcar::Parser # reading response...
         buf = Thread.current[:yahns_rbuf]
-        c = @yahns_client
 
         case resbuf = @resbuf # where are we at the response?
         when nil # common case, catch the response header in a single read
-- 
EW


                 reply	other threads:[~2015-04-09 22:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428618070-17994-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).