yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] favor #nil? instead of "== nil" comparisons in cold code
Date: Wed, 22 Apr 2015 00:59:33 +0000	[thread overview]
Message-ID: <1429664373-30510-1-git-send-email-e@80x24.org> (raw)

We don't need optimized dispatch methods in cold code, so use
the more space-efficient "nil?" method dispatch to save us one
word per-call site for a rough total of 24 bytes saving.
 lib/yahns/config.rb       | 4 ++--
 lib/yahns/http_context.rb | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb
index f4164a9..38f73b7 100644
--- a/lib/yahns/config.rb
+++ b/lib/yahns/config.rb
@@ -18,8 +18,8 @@ def initialize(config_file = nil)
   def _check_in_block(ctx, var)
-    if ctx == nil
-      return var if @block == nil
+    if ctx.nil?
+      return var if @block.nil?
       msg = "#{var} must be called outside of #{@block.type}"
       ctx = Array(ctx)
diff --git a/lib/yahns/http_context.rb b/lib/yahns/http_context.rb
index 13b8686..1554086 100644
--- a/lib/yahns/http_context.rb
+++ b/lib/yahns/http_context.rb
@@ -46,7 +46,7 @@ def after_fork_init
   def __wrap_app(app)
     # input_buffering == false is handled in http_client
-    return app if @client_max_body_size == nil
+    return app if @client_max_body_size.nil?
     require_relative 'cap_input'
     return app if @input_buffering == true

                 reply	other threads:[~2015-04-22  0:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429664373-30510-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).