* [PATCH] favor #nil? instead of "== nil" comparisons in cold code
@ 2015-04-22 0:59 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-04-22 0:59 UTC (permalink / raw)
To: yahns-public; +Cc: Eric Wong
We don't need optimized dispatch methods in cold code, so use
the more space-efficient "nil?" method dispatch to save us one
word per-call site for a rough total of 24 bytes saving.
---
lib/yahns/config.rb | 4 ++--
lib/yahns/http_context.rb | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb
index f4164a9..38f73b7 100644
--- a/lib/yahns/config.rb
+++ b/lib/yahns/config.rb
@@ -18,8 +18,8 @@ def initialize(config_file = nil)
end
def _check_in_block(ctx, var)
- if ctx == nil
- return var if @block == nil
+ if ctx.nil?
+ return var if @block.nil?
msg = "#{var} must be called outside of #{@block.type}"
else
ctx = Array(ctx)
diff --git a/lib/yahns/http_context.rb b/lib/yahns/http_context.rb
index 13b8686..1554086 100644
--- a/lib/yahns/http_context.rb
+++ b/lib/yahns/http_context.rb
@@ -46,7 +46,7 @@ def after_fork_init
def __wrap_app(app)
# input_buffering == false is handled in http_client
- return app if @client_max_body_size == nil
+ return app if @client_max_body_size.nil?
require_relative 'cap_input'
return app if @input_buffering == true
--
2.3.2.465.ga3b75b3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-04-22 0:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-22 0:59 [PATCH] favor #nil? instead of "== nil" comparisons in cold code Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).