From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 58ACA1F738; Wed, 22 Apr 2015 00:59:34 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Cc: Eric Wong Subject: [PATCH] favor #nil? instead of "== nil" comparisons in cold code Date: Wed, 22 Apr 2015 00:59:33 +0000 Message-Id: <1429664373-30510-1-git-send-email-e@80x24.org> List-Id: We don't need optimized dispatch methods in cold code, so use the more space-efficient "nil?" method dispatch to save us one word per-call site for a rough total of 24 bytes saving. --- lib/yahns/config.rb | 4 ++-- lib/yahns/http_context.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/yahns/config.rb b/lib/yahns/config.rb index f4164a9..38f73b7 100644 --- a/lib/yahns/config.rb +++ b/lib/yahns/config.rb @@ -18,8 +18,8 @@ def initialize(config_file = nil) end def _check_in_block(ctx, var) - if ctx == nil - return var if @block == nil + if ctx.nil? + return var if @block.nil? msg = "#{var} must be called outside of #{@block.type}" else ctx = Array(ctx) diff --git a/lib/yahns/http_context.rb b/lib/yahns/http_context.rb index 13b8686..1554086 100644 --- a/lib/yahns/http_context.rb +++ b/lib/yahns/http_context.rb @@ -46,7 +46,7 @@ def after_fork_init def __wrap_app(app) # input_buffering == false is handled in http_client - return app if @client_max_body_size == nil + return app if @client_max_body_size.nil? require_relative 'cap_input' return app if @input_buffering == true -- 2.3.2.465.ga3b75b3