yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] avoid excess allocations for rack.hijack support
@ 2015-05-09  1:05 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-05-09  1:05 UTC (permalink / raw)
  To: yahns-public

Proc object allocation is not cheap, so avoid doing it and
allow Yahns::HttpClient to be assigned as the
env["rack.hijack"] callback for Rack applications.
---
 lib/yahns/http_client.rb | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/lib/yahns/http_client.rb b/lib/yahns/http_client.rb
index 164cac9..a0fd5a4 100644
--- a/lib/yahns/http_client.rb
+++ b/lib/yahns/http_client.rb
@@ -208,7 +208,7 @@ class Yahns::HttpClient < Kgio::Socket # :nodoc:
     # check_client_connection
     if input
       env[REMOTE_ADDR] = @kgio_addr
-      env[RACK_HIJACK] = hijack_proc(env)
+      env[RACK_HIJACK] = self
       env[RACK_INPUT] = input
 
       if k.check_client_connection && @hs.headers?
@@ -228,14 +228,6 @@ class Yahns::HttpClient < Kgio::Socket # :nodoc:
     http_response_write(status, headers, body)
   end
 
-  # this is the env["rack.hijack"] callback exposed to the Rack app
-  def hijack_proc(env)
-    proc do
-      hijack_cleanup
-      env[RACK_HIJACK_IO] = self
-    end
-  end
-
   # called automatically by kgio_write
   def kgio_wait_writable(timeout = self.class.client_timeout)
     super timeout
@@ -268,6 +260,12 @@ class Yahns::HttpClient < Kgio::Socket # :nodoc:
     @input = nil # keep env["rack.input"] accessible, though
   end
 
+  # this is the env["rack.hijack"] callback exposed to the Rack app
+  def call
+    hijack_cleanup
+    @hs.env[RACK_HIJACK_IO] = self
+  end
+
   def response_hijacked(fn)
     hijack_cleanup
     fn.call(self)
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-05-09  1:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-09  1:05 [PATCH] avoid excess allocations for rack.hijack support Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).