From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 205861FABD for ; Sat, 9 May 2015 01:05:53 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] openssl_client: remove shutdown call Date: Sat, 9 May 2015 01:05:53 +0000 Message-Id: <1431133553-30917-1-git-send-email-e@80x24.org> List-Id: OpenSSL::SSL::SSLSocket does not actually respond to a shutdown method, and it would not be safe to call anyways. Merely shutdown at the OS level and let any handling thread clean it up. --- lib/yahns/openssl_client.rb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/yahns/openssl_client.rb b/lib/yahns/openssl_client.rb index 619e316..5842e97 100644 --- a/lib/yahns/openssl_client.rb +++ b/lib/yahns/openssl_client.rb @@ -42,13 +42,8 @@ module Yahns::OpenSSLClient # :nodoc: @ssl.read_nonblock(len, buf, exception: false) end - def shutdown(*args) - @ssl.shutdown(*args) - super # BasicSocket#shutdown - end - def close - @ssl.close + @ssl.close # flushes SSLSocket super # IO#close end end -- EW