From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B5DF21FABD; Sat, 9 May 2015 09:11:30 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Cc: Eric Wong Subject: [PATCH] proxy_pass: favor literal hash over arrays for error responses Date: Sat, 9 May 2015 09:11:29 +0000 Message-Id: <1431162689-1013-1-git-send-email-e@80x24.org> List-Id: Arrays are less verbose, but they have more bytecode overhead which actually matters at runtime. --- extras/proxy_pass.rb | 2 +- lib/yahns/proxy_pass.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extras/proxy_pass.rb b/extras/proxy_pass.rb index b7fc87a..99ca6d6 100644 --- a/extras/proxy_pass.rb +++ b/extras/proxy_pass.rb @@ -200,7 +200,7 @@ class ProxyPass # :nodoc: logger = env['rack.logger'] and Yahns::Log.exception(logger, 'proxy_pass', e) end - [ 502, [ %w(Content-Length 0), %w(Content-Type text/plain) ], [] ] + [ 502, { 'Content-Length' => '0', 'Content-Type' => 'text/plain' }, [] ] end def send_body(input, ures, chunked) diff --git a/lib/yahns/proxy_pass.rb b/lib/yahns/proxy_pass.rb index 15ae17c..7bbab51 100644 --- a/lib/yahns/proxy_pass.rb +++ b/lib/yahns/proxy_pass.rb @@ -243,6 +243,6 @@ class Yahns::ProxyPass # :nodoc: [ 500, [], [] ] rescue => e Yahns::Log.exception(env['rack.logger'], 'proxy_pass', e) - [ 502, [ %w(Content-Length 0), %w(Content-Type text/plain) ], [] ] + [ 502, { 'Content-Length' => '0', 'Content-Type' => 'text/plain' }, [] ] end end -- EW