yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Cc: e@80x24.org
Subject: [PATCH 3/3] http_response: reduce bytecode size
Date: Tue, 30 Jun 2015 03:01:53 +0000	[thread overview]
Message-ID: <1435633313-30223-4-git-send-email-e@80x24.org> (raw)
In-Reply-To: <1435633313-30223-1-git-send-email-e@80x24.org>

This saves around 200 bytes on x86-64 and potentially improves
CPU cache performance.  This does not reduce inline method
cache overhead as String#<< already has optimized dispatch
support (opt_ltlt in insns.def in Ruby 1.9+)
---
 lib/yahns/http_response.rb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index f50c9a1..19075bb 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -108,12 +108,12 @@ module Yahns::HttpResponse # :nodoc:
     end
   end
 
-  def kv_str(key, value)
+  def kv_str(buf, key, value)
     if value.include?("\n".freeze)
       # avoiding blank, key-only cookies with /\n+/
-      value.split(/\n+/).map! { |v| "#{key}: #{v}\r\n" }.join
+      value.split(/\n+/).each { |v| buf << "#{key}: #{v}\r\n" }
     else
-      "#{key}: #{value}\r\n"
+      buf << "#{key}: #{value}\r\n"
     end
   end
 
@@ -144,17 +144,17 @@ module Yahns::HttpResponse # :nodoc:
             offset = $1.to_i
             count = $2.to_i - offset + 1
           end
-          buf << kv_str(key, value)
+          kv_str(buf, key, value)
         when %r{\AConnection\z}i
           # allow Rack apps to tell us they want to drop the client
           alive = false if value =~ /\bclose\b/i
         when %r{\AContent-Length\z}i
           flags |= MSG_MORE if have_more?(value)
-          buf << kv_str(key, value)
+          kv_str(buf, key, value)
         when "rack.hijack"
           hijack = value
         else
-          buf << kv_str(key, value)
+          kv_str(buf, key, value)
         end
       end
       buf << (alive ? "Connection: keep-alive\r\n\r\n".freeze
-- 
EW


      parent reply	other threads:[~2015-06-30  3:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  3:01 [PATCH 0/3] favor newer Rubies for performance Eric Wong
2015-06-30  3:01 ` [PATCH 1/3] generate response status strings dynamically Eric Wong
2015-06-30  3:01 ` [PATCH 2/3] reduce constants and optimize for Ruby 2.2+ Eric Wong
2015-06-30  3:01 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435633313-30223-4-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).