From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] test/test_rack_hijack.rb: try to increase test reliability
Date: Wed, 15 Jul 2015 08:19:39 +0000 [thread overview]
Message-ID: <1436948379-9398-1-git-send-email-e@80x24.org> (raw)
We need to wait for the hijacked process to run and write to the
log before we check it. Since we may not have inotify, try to
trigger a sched_yield() syscall instead.
---
test/test_rack_hijack.rb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/test_rack_hijack.rb b/test/test_rack_hijack.rb
index 5bfc31f..2a9f23e 100644
--- a/test/test_rack_hijack.rb
+++ b/test/test_rack_hijack.rb
@@ -62,6 +62,10 @@ class TestRackHijack < Testcase
assert_equal "zzz", res["X-Test"]
assert_equal "1.1", res.http_version
+ # hope this calls sched_yield() so the forked process runs and writes
+ # to the log.
+ Thread.new { Thread.pass }.join
+
errs = File.readlines(err.path).grep(/DieIfUsed/)
assert_equal([ "INFO #{pid} closed DieIfUsed 1\n",
"INFO #{pid} closed DieIfUsed 2\n" ], errs)
--
EW
reply other threads:[~2015-07-15 8:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/yahns/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436948379-9398-1-git-send-email-e@80x24.org \
--to=e@80x24.org \
--cc=yahns-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/yahns.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).