yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: [PATCH] use opt_str_freeze for Hash#delete
Date: Tue, 21 Jul 2015 20:12:47 +0000	[thread overview]
Message-ID: <1437509567-23655-1-git-send-email-e@80x24.org> (raw)

Unfortunately we cannot rely on the RubyVM for optimizing hash
deletions, yet, so manually freeze for this string since it
(unlike every line after it) is a hot path if handling request
bodies.

Update a comment while we're at it.
---
 lib/yahns/http_response.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index 19075bb..b36f696 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -22,7 +22,7 @@ module Yahns::HttpResponse # :nodoc:
     end
   end
 
-  # avoid GC overhead for frequently used-strings:
+  # avoid GC overhead for frequently used-strings/objects:
   CCC_RESPONSE_START = [ 'HTTP', '/1.1 ' ]
 
   # no point in using one without the other, these have been in Linux
@@ -252,7 +252,7 @@ module Yahns::HttpResponse # :nodoc:
   # returns nil on success
   # returns :close, :wait_writable, or :wait_readable
   def http_100_response(env)
-    env.delete("HTTP_EXPECT") =~ /\A100-continue\z/i or return
+    env.delete('HTTP_EXPECT'.freeze) =~ /\A100-continue\z/i or return
     buf = @hs.response_start_sent ? "100 Continue\r\n\r\nHTTP/1.1 ".freeze
                                   : "HTTP/1.1 100 Continue\r\n\r\n".freeze
 
-- 
EW


                 reply	other threads:[~2015-07-21 20:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437509567-23655-1-git-send-email-e@80x24.org \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).