yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
* [PATCH] use opt_str_freeze for Hash#delete
@ 2015-07-21 20:12 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-07-21 20:12 UTC (permalink / raw)
  To: yahns-public

Unfortunately we cannot rely on the RubyVM for optimizing hash
deletions, yet, so manually freeze for this string since it
(unlike every line after it) is a hot path if handling request
bodies.

Update a comment while we're at it.
---
 lib/yahns/http_response.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb
index 19075bb..b36f696 100644
--- a/lib/yahns/http_response.rb
+++ b/lib/yahns/http_response.rb
@@ -22,7 +22,7 @@ module Yahns::HttpResponse # :nodoc:
     end
   end
 
-  # avoid GC overhead for frequently used-strings:
+  # avoid GC overhead for frequently used-strings/objects:
   CCC_RESPONSE_START = [ 'HTTP', '/1.1 ' ]
 
   # no point in using one without the other, these have been in Linux
@@ -252,7 +252,7 @@ module Yahns::HttpResponse # :nodoc:
   # returns nil on success
   # returns :close, :wait_writable, or :wait_readable
   def http_100_response(env)
-    env.delete("HTTP_EXPECT") =~ /\A100-continue\z/i or return
+    env.delete('HTTP_EXPECT'.freeze) =~ /\A100-continue\z/i or return
     buf = @hs.response_start_sent ? "100 Continue\r\n\r\nHTTP/1.1 ".freeze
                                   : "HTTP/1.1 100 Continue\r\n\r\n".freeze
 
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-21 20:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-21 20:12 [PATCH] use opt_str_freeze for Hash#delete Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../yahns.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).