From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: yahns-public@yhbt.net Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 91B6A63637B for ; Tue, 21 Jul 2015 20:12:47 +0000 (UTC) From: Eric Wong To: yahns-public@yhbt.net Subject: [PATCH] use opt_str_freeze for Hash#delete Date: Tue, 21 Jul 2015 20:12:47 +0000 Message-Id: <1437509567-23655-1-git-send-email-e@80x24.org> List-Id: Unfortunately we cannot rely on the RubyVM for optimizing hash deletions, yet, so manually freeze for this string since it (unlike every line after it) is a hot path if handling request bodies. Update a comment while we're at it. --- lib/yahns/http_response.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/yahns/http_response.rb b/lib/yahns/http_response.rb index 19075bb..b36f696 100644 --- a/lib/yahns/http_response.rb +++ b/lib/yahns/http_response.rb @@ -22,7 +22,7 @@ module Yahns::HttpResponse # :nodoc: end end - # avoid GC overhead for frequently used-strings: + # avoid GC overhead for frequently used-strings/objects: CCC_RESPONSE_START = [ 'HTTP', '/1.1 ' ] # no point in using one without the other, these have been in Linux @@ -252,7 +252,7 @@ module Yahns::HttpResponse # :nodoc: # returns nil on success # returns :close, :wait_writable, or :wait_readable def http_100_response(env) - env.delete("HTTP_EXPECT") =~ /\A100-continue\z/i or return + env.delete('HTTP_EXPECT'.freeze) =~ /\A100-continue\z/i or return buf = @hs.response_start_sent ? "100 Continue\r\n\r\nHTTP/1.1 ".freeze : "HTTP/1.1 100 Continue\r\n\r\n".freeze -- EW