yahns Ruby server user/dev discussion
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: yahns-public@yhbt.net
Subject: Re: [PATCH 2/2] wbuf: avoid corrupted large responses with zero-copy sendfile
Date: Sat, 7 Mar 2015 21:36:44 +0000	[thread overview]
Message-ID: <20150307213644.GA26034@dcvr.yhbt.net> (raw)
In-Reply-To: <1405540640-10669-3-git-send-email-e@80x24.org>

Eric Wong <e@80x24.org> wrote:
> This bug is noticeable on a amd64 FreeBSD 9.2 VM, and possible under
> Linux, too.  This happens as a zero-copy sendfile implementation means
> pages queued for transmission by the sendfile system call should not be
> modified at any point after the sendfile syscall is made.

Btw, this gotcha is now noted in the Linux sendfile(2) manpage:

http://git.kernel.org/cgit/docs/man-pages/man-pages.git/commit/man2/sendfile.2?id=7b6a3299776b5c1c4f169a591434a855d50c68b4

      reply	other threads:[~2015-03-07 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 19:57 [PATCH 0/2] FreeBSD-related fixes (affects Linux users, too) Eric Wong
2014-07-16 19:57 ` [PATCH 1/2] test_server: avoid multiple workers for dead parent check Eric Wong
2014-07-16 19:57 ` [PATCH 2/2] wbuf: avoid corrupted large responses with zero-copy sendfile Eric Wong
2015-03-07 21:36   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/yahns/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307213644.GA26034@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=yahns-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/yahns.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).